Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-36272: Logging ignore recursion error#12312

Merged
vsajip merged 3 commits into
python:masterpython/cpython:masterfrom
remilapeyre:logging-ignore-RecursionErrorremilapeyre/cpython:logging-ignore-RecursionErrorCopy head branch name to clipboard
Mar 15, 2019
Merged

bpo-36272: Logging ignore recursion error#12312
vsajip merged 3 commits into
python:masterpython/cpython:masterfrom
remilapeyre:logging-ignore-RecursionErrorremilapeyre/cpython:logging-ignore-RecursionErrorCopy head branch name to clipboard

Conversation

@remilapeyre

@remilapeyre remilapeyre commented Mar 13, 2019

Copy link
Copy Markdown

Comment thread Lib/logging/__init__.py Outdated
@bedevere-bot

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@remilapeyre

Copy link
Copy Markdown
Author

Hi @vsajip, I have made the requested changes; please review again :)

@bedevere-bot

Copy link
Copy Markdown

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @remilapeyre for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @remilapeyre for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-12339 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 15, 2019
(cherry picked from commit 65f64b1)

Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
@vsajip

vsajip commented Mar 18, 2019

Copy link
Copy Markdown
Member

@Mariatta Any idea what's happened to the 3.7 PR? There doesn't seem to have been one created.

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @remilapeyre for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @remilapeyre for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @remilapeyre for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-12391 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 18, 2019
(cherry picked from commit 65f64b1)

Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
vsajip pushed a commit that referenced this pull request Mar 18, 2019
(cherry picked from commit 65f64b1)

Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.