GH-122390: Replace _Py_GetbaseOpcode with _Py_GetBaseCodeUnit#122942
Merged
markshannon merged 5 commits intoAug 13, 2024
python:mainpython/cpython:mainfrom
faster-cpython:get-base-instructionfaster-cpython/cpython:get-base-instructionCopy head branch name to clipboard
Merged
GH-122390: Replace _Py_GetbaseOpcode with _Py_GetBaseCodeUnit#122942markshannon merged 5 commits intopython:mainpython/cpython:mainfrom faster-cpython:get-base-instructionfaster-cpython/cpython:get-base-instructionCopy head branch name to clipboard
_Py_GetbaseOpcode with _Py_GetBaseCodeUnit#122942markshannon merged 5 commits into
python:mainpython/cpython:mainfrom
faster-cpython:get-base-instructionfaster-cpython/cpython:get-base-instructionCopy head branch name to clipboard
Conversation
iritkatriel
reviewed
Aug 13, 2024
iritkatriel
approved these changes
Aug 13, 2024
Member
Author
|
Failures on emulated JIT builds are a known issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
ENTER_EXECUTORand instrumentation whenever we need to fetch the underlying instruction.ENTER_EXECUTORto opcode 255, to keep the common path fast in_Py_GetBaseCodeUnit._Py_GetBaseCodeUnitas we don't need the additional checks any more._Py_GetBaseOpcode#122390