Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-117139: Replace _PyList_FromArraySteal with stack ref variant#122830

Merged
colesbury merged 1 commit into
python:mainpython/cpython:mainfrom
colesbury:gh-117139-list-stealcolesbury/cpython:gh-117139-list-stealCopy head branch name to clipboard
Aug 12, 2024
Merged

gh-117139: Replace _PyList_FromArraySteal with stack ref variant#122830
colesbury merged 1 commit into
python:mainpython/cpython:mainfrom
colesbury:gh-117139-list-stealcolesbury/cpython:gh-117139-list-stealCopy head branch name to clipboard

Conversation

@colesbury

@colesbury colesbury commented Aug 8, 2024

Copy link
Copy Markdown
Contributor

This replaces _PyList_FromArraySteal with _PyList_FromStackRefSteal. It's functionally equivalent, but takes a _PyStackRef array instead of an array of PyObject pointers.

This replaces `_PyList_FromArraySteal` with `_PyList_FromStackRefSteal`.
It's functionally equivalent, but takes a `_PyStackRef` array instead of
an array of `PyObject` pointers.

Co-authored-by: Ken Jin <kenjin@python.org>
@colesbury

Copy link
Copy Markdown
Contributor Author

@colesbury colesbury marked this pull request as ready for review August 8, 2024 17:48
@colesbury colesbury requested a review from markshannon as a code owner August 8, 2024 17:48

@DinoV DinoV left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@colesbury colesbury merged commit ab094d1 into python:main Aug 12, 2024
@colesbury colesbury deleted the gh-117139-list-steal branch August 12, 2024 18:49
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
python#122830)

This replaces `_PyList_FromArraySteal` with `_PyList_FromStackRefSteal`.
It's functionally equivalent, but takes a `_PyStackRef` array instead of
an array of `PyObject` pointers.

Co-authored-by: Ken Jin <kenjin@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.