GH-122155: Track local variables between pops and pushes in cases generator#122286
Merged
markshannon merged 13 commits intoAug 1, 2024
python:mainpython/cpython:mainfrom
faster-cpython:cases-gen-track-localsfaster-cpython/cpython:cases-gen-track-localsCopy head branch name to clipboard
Merged
GH-122155: Track local variables between pops and pushes in cases generator#122286markshannon merged 13 commits intopython:mainpython/cpython:mainfrom faster-cpython:cases-gen-track-localsfaster-cpython/cpython:cases-gen-track-localsCopy head branch name to clipboard
markshannon merged 13 commits into
python:mainpython/cpython:mainfrom
faster-cpython:cases-gen-track-localsfaster-cpython/cpython:cases-gen-track-localsCopy head branch name to clipboard
Conversation
squeaky-pl
reviewed
Jul 27, 2024
squeaky-pl
reviewed
Jul 27, 2024
picnixz
reviewed
Jul 27, 2024
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Paweł Piotr Przeradowski <showerproof86@gmail.com>
iritkatriel
reviewed
Jul 31, 2024
iritkatriel
approved these changes
Jul 31, 2024
Member
Author
|
JIT failures are unrelated (an llvm package issue) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current design of the cases generator assumes that the code generator can infer all it needs to know from looking at the stack comments of individual micro-ops. However this isn't true within a tier 1 instruction if the intermediate stack grows during an instruction.
This PR tracks local values during micro ops, between them being popped from the stack and pushed back to the stack.