[2.7] bpo-36019: Use pythontest.net instead of example.com in network tests (GH-11941)#12177
[2.7] bpo-36019: Use pythontest.net instead of example.com in network tests (GH-11941)#12177
Conversation
vstinner
left a comment
There was a problem hiding this comment.
test_urllib2net.py: More tests still use "http://www.example.com/":
- CloseSocketTest.test_close()
- test_fileno() and test_custom_headers() of OtherNetworkTests.
- TimeoutTest
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
vstinner
left a comment
There was a problem hiding this comment.
I blocked access to example.com from my laptop using:
#11941 (review)
Without the test, test_urllib2net fails. With the change, test_urllib2net pass. Command "./python -m test -u all test_urllib2net".
I also ran "./python -m test -j0 -u all -r" with the change: SUCCESS.
https://bugs.python.org/issue36019