[3.13] gh-120683: Fix an error in logging.LogRecord timestamp (GH-120709)#120933
Merged
serhiy-storchaka merged 1 commit intoJun 24, 2024
python:3.13python/cpython:3.13from
miss-islington:backport-1500a23-3.13miss-islington/cpython:backport-1500a23-3.13Copy head branch name to clipboard
Merged
[3.13] gh-120683: Fix an error in logging.LogRecord timestamp (GH-120709)#120933serhiy-storchaka merged 1 commit intopython:3.13python/cpython:3.13from miss-islington:backport-1500a23-3.13miss-islington/cpython:backport-1500a23-3.13Copy head branch name to clipboard
serhiy-storchaka merged 1 commit into
python:3.13python/cpython:3.13from
miss-islington:backport-1500a23-3.13miss-islington/cpython:backport-1500a23-3.13Copy head branch name to clipboard
Conversation
This was referenced Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integer part of the timestamp can be rounded up, while the millisecond
calculation truncates, causing the log timestamp to be wrong by up to 999 ms
(affected roughly 1 in 8 million timestamps).
(cherry picked from commit 1500a23)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com