Fix typo in UOp Pair Stats Output#120846
Closed
JeffersGlass wants to merge 2 commits into
python:mainpython/cpython:mainfrom
JeffersGlass:fix-uop-pair-stats-prefixJeffersGlass/cpython:fix-uop-pair-stats-prefixCopy head branch name to clipboard
Closed
Fix typo in UOp Pair Stats Output#120846JeffersGlass wants to merge 2 commits intopython:mainpython/cpython:mainfrom JeffersGlass:fix-uop-pair-stats-prefixJeffersGlass/cpython:fix-uop-pair-stats-prefixCopy head branch name to clipboard
JeffersGlass wants to merge 2 commits into
python:mainpython/cpython:mainfrom
JeffersGlass:fix-uop-pair-stats-prefixJeffersGlass/cpython:fix-uop-pair-stats-prefixCopy head branch name to clipboard
Conversation
Eclips4
approved these changes
Jun 23, 2024
Member
|
Thanks for the PR, but the code with the typo has since been deleted in #137189. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a one-line fix - when outputting pystats, the stats for UOps are mostly output with the prefix
uops, but the pair counts are output with the prefixuop. This causes the names of the ops appear with an additional[in front of them when printed.This is a minor fix with no corresponding issue or discussion.