Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-27313: Avoid test_ttk_guionly ComboboxTest fail with macOS Cocoa Tk#12011

Merged
ned-deily merged 1 commit into
python:masterpython/cpython:masterfrom
ned-deily:bpo-27313-quartz-combobox-testned-deily/cpython:bpo-27313-quartz-combobox-testCopy head branch name to clipboard
Feb 24, 2019
Merged

bpo-27313: Avoid test_ttk_guionly ComboboxTest fail with macOS Cocoa Tk#12011
ned-deily merged 1 commit into
python:masterpython/cpython:masterfrom
ned-deily:bpo-27313-quartz-combobox-testned-deily/cpython:bpo-27313-quartz-combobox-testCopy head branch name to clipboard

Conversation

@ned-deily

@ned-deily ned-deily commented Feb 24, 2019

Copy link
Copy Markdown
Member

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @ned-deily for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@ned-deily ned-deily deleted the bpo-27313-quartz-combobox-test branch February 24, 2019 07:28
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 24, 2019
…Tk (pythonGH-12011)

(cherry picked from commit aeca373)

Co-authored-by: Ned Deily <nad@python.org>
@bedevere-bot

Copy link
Copy Markdown

GH-12012 is a backport of this pull request to the 3.7 branch.

@bedevere-bot

Copy link
Copy Markdown

GH-12013 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 24, 2019
…Tk (pythonGH-12011)

(cherry picked from commit aeca373)

Co-authored-by: Ned Deily <nad@python.org>
miss-islington added a commit that referenced this pull request Feb 24, 2019
…Tk (GH-12011)

(cherry picked from commit aeca373)

Co-authored-by: Ned Deily <nad@python.org>
ned-deily added a commit that referenced this pull request Feb 24, 2019
…Tk (GH-12011) (GH-12013)

(cherry picked from commit aeca373)

Co-authored-by: Ned Deily <nad@python.org>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Oct 11, 2024
In aeca373 (PR pythongh-12011, issue pythongh-71500), test_identify() was changed
to expect different results on Darwin. This workaround is only needed
for some variants of Tk/Tcl on macOS, so we now allow both the
workaround and the generic results for these tests.
erlend-aasland added a commit that referenced this pull request Oct 13, 2024
In aeca373 (PR gh-12011, issue gh-71500), test_identify() was changed to expect different results on Darwin. Ned's fix was later adjusted by e52f9be. This workaround is only needed for some variants of Tk/Tcl on macOS, so we now allow both the workaround and the generic results for these tests.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 13, 2024
…H-125335)

In aeca373 (PR pythongh-12011, issue pythongh-71500), test_identify() was changed to expect different results on Darwin. Ned's fix was later adjusted by e52f9be. This workaround is only needed for some variants of Tk/Tcl on macOS, so we now allow both the workaround and the generic results for these tests.
(cherry picked from commit 4197a79)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 13, 2024
…H-125335)

In aeca373 (PR pythongh-12011, issue pythongh-71500), test_identify() was changed to expect different results on Darwin. Ned's fix was later adjusted by e52f9be. This workaround is only needed for some variants of Tk/Tcl on macOS, so we now allow both the workaround and the generic results for these tests.
(cherry picked from commit 4197a79)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Oct 13, 2024
) (#125391)

In aeca373 (PR gh-12011, issue gh-71500), test_identify() was changed to expect different results on Darwin. Ned's fix was later adjusted by e52f9be. This workaround is only needed for some variants of Tk/Tcl on macOS, so we now allow both the workaround and the generic results for these tests.
(cherry picked from commit 4197a79)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Oct 13, 2024
) (#125390)

In aeca373 (PR gh-12011, issue gh-71500), test_identify() was changed to expect different results on Darwin. Ned's fix was later adjusted by e52f9be. This workaround is only needed for some variants of Tk/Tcl on macOS, so we now allow both the workaround and the generic results for these tests.
(cherry picked from commit 4197a79)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OS-mac tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.