Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.5] bpo-35411: Skip test_urllib2net FTP tests on Travis CI (GH-10907)#11874

Merged
larryhastings merged 2 commits into
python:3.5python/cpython:3.5from
vstinner:travis_skip_ftp35Copy head branch name to clipboard
Feb 25, 2019
Merged

[3.5] bpo-35411: Skip test_urllib2net FTP tests on Travis CI (GH-10907)#11874
larryhastings merged 2 commits into
python:3.5python/cpython:3.5from
vstinner:travis_skip_ftp35Copy head branch name to clipboard

Conversation

@vstinner

@vstinner vstinner commented Feb 15, 2019

Copy link
Copy Markdown
Member

On Travis CI, FTP tests of test_urllib2net randomly fail with "425
Security: Bad IP connecting".

(cherry picked from commit c11b3b1)

https://bugs.python.org/issue35411

On Travis CI, FTP tests of test_urllib2net randomly fail with "425
Security: Bad IP connecting".

(cherry picked from commit c11b3b1)
@vstinner

Copy link
Copy Markdown
Member Author

@larryhastings, @ned-deily or @ambv: Can you please merge this fix to unblock PR #11869 security fix?

@eamanu eamanu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@larryhastings larryhastings left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vstinner

Copy link
Copy Markdown
Member Author

Good, Travis CI succeeded ;-)

@larryhastings larryhastings merged commit 8bcbc78 into python:3.5 Feb 25, 2019
@bedevere-bot

Copy link
Copy Markdown

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!

@larryhastings

Copy link
Copy Markdown
Contributor

Thanks for the fix! Now I can merge the other stuff.

@vstinner vstinner deleted the travis_skip_ftp35 branch April 29, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.