Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[3.4] bpo-34656: Avoid relying on signed overflow in _pickle memos (GH-9261)#11870

Merged
larryhastings merged 3 commits into
python:3.4python/cpython:3.4from
vstinner:pickle_load34Copy head branch name to clipboard
Feb 25, 2019
Merged

[3.4] bpo-34656: Avoid relying on signed overflow in _pickle memos (GH-9261)#11870
larryhastings merged 3 commits into
python:3.4python/cpython:3.4from
vstinner:pickle_load34Copy head branch name to clipboard

Conversation

@vstinner

@vstinner vstinner commented Feb 15, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

(cherry picked from commit a4ae828)

https://bugs.python.org/issue34656

@vstinner

vstinner commented Feb 15, 2019

Copy link
Copy Markdown
Member Author

Please double-check this one, I had to fix compilation error on Windows (second commit). cc @mcepl

@mcepl

mcepl commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

Yeah, it looks sensible. I had the same problem with Windows compilers myself many times. +1 from me.

@vstinner

vstinner commented Feb 15, 2019

Copy link
Copy Markdown
Member Author

Yeah, it looks sensible. I had the same problem with Windows compilers myself many times. +1 from me.

Can you please officially "approve" the change?

@vstinner

vstinner commented Feb 15, 2019

Copy link
Copy Markdown
Member Author

AppVeyor build succeeded

Aha, my 2nd commit fixed compilation on Windows (and tests pass).

@mcepl

mcepl commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

Yeah, it looks sensible. I had the same problem with Windows compilers myself many times. +1 from me.

Can you please officially "approve" the change?

I don't see the button anywhere. I don't think I have any bits required.

@vstinner

vstinner commented Feb 15, 2019

Copy link
Copy Markdown
Member Author

I don't see the button anywhere. I don't think I have any bits required.

Anyone can approve/reject a change: go to the "Files changes" tab and click on [Review changes] button, then select (o) Approve.

mcepl
mcepl approved these changes Feb 15, 2019
View reviewed changes

@mcepl mcepl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is basically my original patch (which is running in openSUSE) with additional fixes for Windows compilation. Looks good.

@mcepl

mcepl commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

Like this?

@vstinner

vstinner commented Feb 15, 2019

Copy link
Copy Markdown
Member Author

Like this?

Yes! Thanks :-)

@larryhastings larryhastings merged commit 4b42d57 into python:3.4 Feb 25, 2019
@bedevere-bot

bedevere-bot commented Feb 25, 2019

Copy link
Copy Markdown

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!

@larryhastings

larryhastings commented Feb 25, 2019

Copy link
Copy Markdown
Contributor

Thanks for the backport!

@vstinner vstinner deleted the pickle_load34 branch April 29, 2019 14:01
@httpsgithubcomxcainiao httpsgithubcomxcainiao mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

+1 more reviewer

@mcepl mcepl mcepl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vstinner @mcepl @bedevere-bot @larryhastings @gpshead @the-knights-who-say-ni @benjaminp
Morty Proxy This is a proxified and sanitized view of the page, visit original site.