[3.4] bpo-35746: Fix segfault in ssl's cert parser (GH-11569)#11868
Merged
larryhastings merged 2 commits intoFeb 25, 2019
Merged
[3.4] bpo-35746: Fix segfault in ssl's cert parser (GH-11569)#11868larryhastings merged 2 commits into
larryhastings merged 2 commits into
Conversation
Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL distribution points with empty DP or URI correctly. A malicious or buggy certificate can result into segfault. Vulnerability (TALOS-2018-0758) reported by Colin Read and Nicolas Edet of Cisco. Signed-off-by: Christian Heimes <christian@python.org> (cherry picked from commit a37f524)
Member
Author
|
I cannot test manually on my Fedora 29: compilation of the _ssl module fails with OpenSSL 1.1.1, but the test passed on Travis CI ("[112/391] test_ssl") and AppVeyor ("[360/391] test_ssl"). |
Contributor
|
@vstinner You should be able to install compat-openssl10-devel and test with that one instead. You might need to remove openssl-devel first. |
|
@larryhastings: Please replace |
Contributor
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL
distribution points with empty DP or URI correctly. A malicious or buggy
certificate can result into segfault.
Vulnerability (TALOS-2018-0758) reported by Colin Read and Nicolas
Edet of Cisco.
Signed-off-by: Christian Heimes christian@python.org
(cherry picked from commit a37f524)
https://bugs.python.org/issue35746