GH-118095: Convert DEOPT_IFs on likely side exits to EXIT_IFs#118106
Merged
markshannon merged 1 commit intoApr 24, 2024
python:mainpython/cpython:mainfrom
faster-cpython:convert-deopts-to-exitsfaster-cpython/cpython:convert-deopts-to-exitsCopy head branch name to clipboard
Merged
GH-118095: Convert DEOPT_IFs on likely side exits to EXIT_IFs#118106markshannon merged 1 commit intopython:mainpython/cpython:mainfrom faster-cpython:convert-deopts-to-exitsfaster-cpython/cpython:convert-deopts-to-exitsCopy head branch name to clipboard
markshannon merged 1 commit into
python:mainpython/cpython:mainfrom
faster-cpython:convert-deopts-to-exitsfaster-cpython/cpython:convert-deopts-to-exitsCopy head branch name to clipboard
Conversation
Member
Author
|
CI failures are not new. |
gvanrossum
approved these changes
Apr 23, 2024
gvanrossum
left a comment
Member
There was a problem hiding this comment.
LG, but what about the benchmark claiming it's 1% slower?
| // Reserve space for nuops (+ _SET_IP + _EXIT_TRACE) | ||
| int nuops = expansion->nuops; | ||
| RESERVE(nuops); | ||
| RESERVE(nuops + 1); /* One extra for exit */ |
Member
Author
There was a problem hiding this comment.
It seems likely to be the same issue, but I haven't checked.
Member
Author
That's the tier 2 interpreter. The generated code for tier 1 is unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stats show about a 10% increase in traces executed and uops executed, with a corresponding reduction in tier 1 instructions executed.