Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-118023: Fix reference leak#118025

Merged
iritkatriel merged 1 commit into
python:mainpython/cpython:mainfrom
Eclips4:issue-118023Eclips4/cpython:issue-118023Copy head branch name to clipboard
Apr 18, 2024
Merged

gh-118023: Fix reference leak#118025
iritkatriel merged 1 commit into
python:mainpython/cpython:mainfrom
Eclips4:issue-118023Eclips4/cpython:issue-118023Copy head branch name to clipboard

Conversation

@Eclips4

@Eclips4 Eclips4 commented Apr 18, 2024

Copy link
Copy Markdown
Member

@Eclips4

Eclips4 commented Apr 18, 2024

Copy link
Copy Markdown
Member Author

Before this PR:

./python.exe -m test -R 3:3 test_compile
Using random seed: 114949622
0:00:00 load avg: 4.27 Run 1 test sequentially
0:00:00 load avg: 4.27 [1/1] test_compile
beginning 6 repetitions. Showing number of leaks (. for 0 or less, X for 10 or more)
123:456
XX4 444
test_compile leaked [2, 2, 2] references, sum=6
test_compile leaked [4, 4, 4] memory blocks, sum=12
test_compile failed (reference leak)

== Tests result: FAILURE ==

1 test failed:
    test_compile

Total duration: 12.2 sec
Total tests: run=164 skipped=1
Total test files: run=1/1 failed=1
Result: FAILURE

After this PR:

./python.exe -m test -R 3:3 test_compile
Using random seed: 1010092619
0:00:00 load avg: 3.37 Run 1 test sequentially
0:00:00 load avg: 3.37 [1/1] test_compile
beginning 6 repetitions. Showing number of leaks (. for 0 or less, X for 10 or more)
123:456
XX. ...

== Tests result: SUCCESS ==

1 test OK.

Total duration: 12.3 sec
Total tests: run=164 skipped=1
Total test files: run=1/1
Result: SUCCESS

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@iritkatriel iritkatriel enabled auto-merge (squash) April 18, 2024 07:09
@iritkatriel iritkatriel merged commit cd7cf15 into python:main Apr 18, 2024
@Eclips4 Eclips4 deleted the issue-118023 branch April 18, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.