Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-113317: Finish splitting Argument Clinic into sub-files#117513

Merged
vstinner merged 1 commit into
python:mainpython/cpython:mainfrom
vstinner:ac_splitvstinner/cpython:ac_splitCopy head branch name to clipboard
Apr 4, 2024
Merged

gh-113317: Finish splitting Argument Clinic into sub-files#117513
vstinner merged 1 commit into
python:mainpython/cpython:mainfrom
vstinner:ac_splitvstinner/cpython:ac_splitCopy head branch name to clipboard

Conversation

@vstinner

@vstinner vstinner commented Apr 3, 2024

Copy link
Copy Markdown
Member

Add libclinic.parser module and move the following classes and functions there:

  • Parser
  • PythonParser
  • create_parser_namespace()

Add libclinic.dsl_parser module and move the following classes, functions and variables there:

  • ConverterArgs
  • DSLParser
  • FunctionNames
  • IndentStack
  • ParamState
  • StateKeeper
  • eval_ast_expr()
  • unsupported_special_methods

Add libclinic.app module and move the Clinic class there.

Add libclinic.cli module and move the following functions there:

  • create_cli()
  • main()
  • parse_file()
  • run_clinic()

Add libclinic.parser module and move the following classes and
functions there:

* Parser
* PythonParser
* create_parser_namespace()

Add libclinic.dsl_parser module and move the following classes,
functions and variables there:

* ConverterArgs
* DSLParser
* FunctionNames
* IndentStack
* ParamState
* StateKeeper
* eval_ast_expr()
* unsupported_special_methods

Add libclinic.app module and move the Clinic class there.

Add libclinic.cli module and move the following functions there:

* create_cli()
* main()
* parse_file()
* run_clinic()
Comment thread Tools/clinic/libclinic/app.py
@vstinner

vstinner commented Apr 3, 2024

Copy link
Copy Markdown
Member Author

See also #115542

@vstinner vstinner merged commit dc54714 into python:main Apr 4, 2024
@vstinner vstinner deleted the ac_split branch April 4, 2024 09:09
@vstinner

vstinner commented Apr 4, 2024

Copy link
Copy Markdown
Member Author

Merged, thanks for the review @erlend-aasland.

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…hon#117513)

Add libclinic.parser module and move the following classes and
functions there:

* Parser
* PythonParser
* create_parser_namespace()

Add libclinic.dsl_parser module and move the following classes,
functions and variables there:

* ConverterArgs
* DSLParser
* FunctionNames
* IndentStack
* ParamState
* StateKeeper
* eval_ast_expr()
* unsupported_special_methods

Add libclinic.app module and move the Clinic class there.

Add libclinic.cli module and move the following functions there:

* create_cli()
* main()
* parse_file()
* run_clinic()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Argument Clinic: split out global stateless helpers and constants from clinic.py

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.