gh-117348: Refactored RawConfigParser._read for simplicity and comprehensibility#117372

Merged

jaraco merged 23 commits into

python:mainfrom

jaraco:feature/refactor-configparser-read-complexity

Mar 29, 2024

Commits on Mar 29, 2024

Extract method for _read_inner, reducing complexity and indentation by 1.
jaraco
committed
a25ac00
Copy full SHA for a25ac00
Extract method for _raise_all and yield ParseErrors from _read_inner.
Show description for 1e69aae
jaraco
committed
1e69aae
Copy full SHA for 1e69aae
Prefer iterators to splat expansion and literal indexing.
jaraco
committed
8c47781
Copy full SHA for 8c47781
Extract method for _strip_comments. Reduces complexity by 7.
jaraco
committed
7479814
Copy full SHA for 7479814
Model the file lines in a class to encapsulate the comment status and cleaned value.
jaraco
committed
a2fffee
Copy full SHA for a2fffee
Encapsulate the read state as a dataclass
jaraco
committed
23468cb
Copy full SHA for 23468cb
Extract _handle_continuation_line and _handle_rest methods. Reduces complexity by 8.
jaraco
committed
3d1ef0a
Copy full SHA for 3d1ef0a
Reindent
jaraco
committed
071baeb
Copy full SHA for 071baeb
At least for now, collect errors in the ReadState
jaraco
committed
81f4ce2
Copy full SHA for 81f4ce2
Check for missing section header separately.
jaraco
committed
8942cc1
Copy full SHA for 8942cc1
Extract methods for _handle_header and _handle_option. Reduces complexity by 6.
jaraco
committed
1e72168
Copy full SHA for 1e72168
Remove unreachable code. Reduces complexity by 4.
jaraco
committed
0dfd797
Copy full SHA for 0dfd797
Remove unreachable branch
jaraco
committed
77ed897
Copy full SHA for 77ed897
Handle error condition early. Reduces complexity by 1.
jaraco
committed
76f42d3
Copy full SHA for 76f42d3
Add blurb
jaraco
committed
c18a2bb
Copy full SHA for c18a2bb
Move _raise_all to ParsingError, as its behavior is most closely related to the exception class and not the reader.
jaraco
committed
97aa785
Copy full SHA for 97aa785
Split _strip* into separate methods.
jaraco
committed
d310cb4
Copy full SHA for d310cb4
Refactor _strip_full to compute the strip just once and use 'not any' to determine the factor.
jaraco
committed
f2a355c
Copy full SHA for f2a355c
Replace use of 'sys.maxsize' with direct computation of the stripped value.
jaraco
committed
2492614
Copy full SHA for 2492614
Extract has_comments as a dynamic property.
jaraco
committed
4968591
Copy full SHA for 4968591
Implement clean as a cached property.
jaraco
committed
7d807bb
Copy full SHA for 7d807bb
Model comment prefixes in the RawConfigParser within a prefixes namespace.
jaraco
committed
29cb20f
Copy full SHA for 29cb20f
Use a regular expression to search for the first match.
Show description for c834c35
jaraco
committed
c834c35
Copy full SHA for c834c35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-117348: Refactored RawConfigParser._read for simplicity and comprehensibility#117372

gh-117348: Refactored RawConfigParser._read for simplicity and comprehensibility#117372
jaraco merged 23 commits into
python:mainpython/cpython:mainfrom
jaraco:feature/refactor-configparser-read-complexityjaraco/cpython:feature/refactor-configparser-read-complexityCopy head branch name to clipboard

Commits on Mar 29, 2024

Extract method for _read_inner, reducing complexity and indentation by 1.

Extract method for _raise_all and yield ParseErrors from _read_inner.

Prefer iterators to splat expansion and literal indexing.

Extract method for _strip_comments. Reduces complexity by 7.

Model the file lines in a class to encapsulate the comment status and cleaned value.

Encapsulate the read state as a dataclass

Extract _handle_continuation_line and _handle_rest methods. Reduces complexity by 8.

Reindent

At least for now, collect errors in the ReadState

Check for missing section header separately.

Extract methods for _handle_header and _handle_option. Reduces complexity by 6.

Remove unreachable code. Reduces complexity by 4.

Remove unreachable branch

Handle error condition early. Reduces complexity by 1.

Add blurb

Move _raise_all to ParsingError, as its behavior is most closely related to the exception class and not the reader.

Split _strip* into separate methods.

Refactor _strip_full to compute the strip just once and use 'not any' to determine the factor.

Replace use of 'sys.maxsize' with direct computation of the stripped value.

Extract has_comments as a dynamic property.

Implement clean as a cached property.

Model comment prefixes in the RawConfigParser within a prefixes namespace.

Use a regular expression to search for the first match.

Search code, repositories, users, issues, pull requests...

Uh oh!

Commits

Commits on Mar 29, 2024