[3.10] gh-117187: Fix XML tests for vanilla Expat <2.6.0 (GH-117203)#117246
Merged
ambv merged 1 commit intoMar 27, 2024
python:3.10python/cpython:3.10from
miss-islington:backport-9f74e86-3.10miss-islington/cpython:backport-9f74e86-3.10Copy head branch name to clipboard
Merged
[3.10] gh-117187: Fix XML tests for vanilla Expat <2.6.0 (GH-117203)#117246ambv merged 1 commit intopython:3.10python/cpython:3.10from miss-islington:backport-9f74e86-3.10miss-islington/cpython:backport-9f74e86-3.10Copy head branch name to clipboard
ambv merged 1 commit into
python:3.10python/cpython:3.10from
miss-islington:backport-9f74e86-3.10miss-islington/cpython:backport-9f74e86-3.10Copy head branch name to clipboard
Conversation
) This fixes XML unittest fallout from the python#115398 security fix. When configured using `--with-system-expat` on systems with older pre 2.6.0 versions of libexpat, our unittests were failing. * sax|etree: Simplify Expat version guard where simplifiable Idea by Matěj Cepl * sax|etree: Fix reparse deferral tests for vanilla Expat <2.6.0 This *does not fix* the case of distros with an older version of libexpat with the 2.6.0 feature backported as a security fix. (Ubuntu is a known example of this with its libexpat1 2.5.0-2ubunutu0.1 package) (cherry picked from commit 9f74e86) Co-authored-by: Sebastian Pipping <sebastian@pipping.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes XML unittest fallout from the #115398 security fix. When configured using
--with-system-expaton systems with older pre 2.6.0 versions of libexpat, our unittests were failing.Idea by Matěj Cepl
This does not fix the case of distros with an older version of libexpat with the 2.6.0 feature backported as a security fix. (Ubuntu is a known example of this with its libexpat1 2.5.0-2ubunutu0.1 package)
(cherry picked from commit 9f74e86)
Co-authored-by: Sebastian Pipping sebastian@pipping.org