gh-111926: Make weakrefs thread-safe in free-threaded builds#117168

Merged

colesbury merged 67 commits into

python:mainfrom

mpage:gh-111926-thread-safe-weakref

Apr 8, 2024

Commits on Mar 22, 2024

Add _PyObject_SetMaybeWeakref
Show description for 9bf3820
mpage
committed
9bf3820
Copy full SHA for 9bf3820
Make PyWeakref_NewRef thread-safe
mpage
committed
75603c1
Copy full SHA for 75603c1
Make PyWeakref_NewProxy thread-safe
mpage
committed
c4f8453
Copy full SHA for c4f8453
Make weakref___new___ thread-safe
mpage
committed
ece230f
Copy full SHA for ece230f
Make weakref_hash thread-safe
mpage
committed
9acae59
Copy full SHA for 9acae59
Make _PyStaticType_ClearWeakRefs thread-safe
mpage
committed
6d00f51
Copy full SHA for 6d00f51
Handle multiple weakrefs
mpage
committed
363a1a6
Copy full SHA for 363a1a6
Make _PyWeakref_GetWeakrefCount thread-safe
mpage
committed
c9b3bf9
Copy full SHA for c9b3bf9
Make _weakref._getweakrefs thread-safe
mpage
committed
b7b3315
Copy full SHA for b7b3315
Make weakref clearing in subtype_dealloc thread-safe
mpage
committed
e6e2d28
Copy full SHA for e6e2d28
Fix incorrect size in test_sys for weakref/proxy
mpage
committed
0d259d1
Copy full SHA for 0d259d1
Use a once flag
mpage
committed
7cc523b
Copy full SHA for 7cc523b
Simplify clearing callback-free refs
mpage
committed
11be247
Copy full SHA for 11be247
Rationalize naming
mpage
committed
8fcd33f
Copy full SHA for 8fcd33f
Fix warning
mpage
committed
1e1e609
Copy full SHA for 1e1e609
Simplify ClearWeakRefs
mpage
committed
19a274e
Copy full SHA for 19a274e
Refactor clearing code
mpage
committed
817a5a3
Copy full SHA for 817a5a3
Protect wr_object with a separate mutex
mpage
committed
d493e7d
Copy full SHA for d493e7d
Switch to a sharded lock for linked list and object
mpage
committed
88078a6
Copy full SHA for 88078a6
Fix formatting
mpage
committed
dc1f651
Copy full SHA for dc1f651
Remove vestigial include
mpage
committed
37c511a
Copy full SHA for 37c511a
Make sure we set the cleared flag
mpage
committed
ccaeded
Copy full SHA for ccaeded

Commits on Mar 24, 2024

Use `Py_TryIncref` when returning the ref
Show description for 6a50381
mpage
committed
6a50381
Copy full SHA for 6a50381
Don't leak ref if initialization fails
mpage
committed
d998d1b
Copy full SHA for d998d1b
Remove clinic critical section directives for `_weakref` module
Show description for 37076b5
mpage
committed
37076b5
Copy full SHA for 37076b5

Commits on Mar 25, 2024

Support async removal of dead weakrefs from WeakValueDictionary
mpage
committed
a07d2db
Copy full SHA for a07d2db

Commits on Mar 27, 2024

Only use the striped lock
mpage
committed
a901848
Copy full SHA for a901848
Refactor weakref creation
mpage
committed
8c85fd3
Copy full SHA for 8c85fd3
Fixups
mpage
committed
0021bc5
Copy full SHA for 0021bc5
Fix formatting
mpage
committed
40d99d4
Copy full SHA for 40d99d4
Use QSBR to avoid locking in PyType_IsSubtype
mpage
committed
dd922b1
Copy full SHA for dd922b1
Remove unnecessary include
mpage
committed
681872e
Copy full SHA for 681872e
Fix unused function warning in default builds
mpage
committed
8982831
Copy full SHA for 8982831

Commits on Mar 28, 2024

Check for callable proxy
mpage
committed
334c766
Copy full SHA for 334c766

Commits on Mar 29, 2024

Refactor weakref creation
mpage
committed
0549445
Copy full SHA for 0549445
Simplify comment
mpage
committed
eb12c06
Copy full SHA for eb12c06
Get rid of GetWeakrefCountThreadsafe
mpage
committed
700cf4c
Copy full SHA for 700cf4c
Don't explicitly zero initialize striped lock
mpage
committed
63200cd
Copy full SHA for 63200cd
Indent conditional define
mpage
committed
e9eed72
Copy full SHA for e9eed72
Use non-atomic loads while we hold the lock
mpage
committed
e3d5779
Copy full SHA for e3d5779
Refactor a _PyWeakref_GET_REF and _PyWeakref_IS_DEAD to share more code
mpage
committed
f31f1e5
Copy full SHA for f31f1e5
Merge helper functions for clearing weakrefs
mpage
committed
b5c9561
Copy full SHA for b5c9561
Make _PyStaticType_ClearWeakRefs have one implementation for default and free-threaded builds
mpage
committed
93425e6
Copy full SHA for 93425e6
Make sure we're able to index into the striped lock even if GC clears us
mpage
committed
89edf02
Copy full SHA for 89edf02
Consolidate implementations of _PyWeakref_ClearRef and gc_clear
mpage
committed
7f73480
Copy full SHA for 7f73480
Rename `_Py_TryIncref` to `_Py_TryIncrefCompare`
mpage
committed
d742ed1
Copy full SHA for d742ed1
Add `_Py_TryIncref`
mpage
committed
37f9ceb
Copy full SHA for 37f9ceb
Refactor `weakref._getweakrefs` to have one implementation
mpage
committed
fb9eee5
Copy full SHA for fb9eee5
Refactor to have one implementation for `PyObject_ClearWeakRefs`
mpage
committed
d760b99
Copy full SHA for d760b99
Revert "Use QSBR to avoid locking in PyType_IsSubtype"
Show description for 491e4ff
mpage
committed
491e4ff
Copy full SHA for 491e4ff
Accept thread unsafety when checking subtype for now
mpage
committed
531a076
Copy full SHA for 531a076
Update modules to use PyWeakref_GetRef
Show description for ed280d8
mpage
committed
ed280d8
Copy full SHA for ed280d8
Merge branch 'main' into gh-111926-thread-safe-weakref
mpage
committed
2750787
Copy full SHA for 2750787
Use a pointer to the appropriate mutex rather than a copy of the object ptr
mpage
committed
5e7c8bb
Copy full SHA for 5e7c8bb
Fix formatting
mpage
committed
37c9529
Copy full SHA for 37c9529
Merge implementation of try_reuse_basic_ref
mpage
committed
fece88d
Copy full SHA for fece88d

Commits on Apr 2, 2024

Remove redundant gc untrack
mpage
committed
7a86e35
Copy full SHA for 7a86e35
Update comment
mpage
committed
f89edd1
Copy full SHA for f89edd1
Add missing braces
mpage
committed
5a0b976
Copy full SHA for 5a0b976
Use Py_ssize_t for tracking number of items
mpage
committed
9e67740
Copy full SHA for 9e67740
Tighten up clearing basic refs/proxies
mpage
committed
55a211f
Copy full SHA for 55a211f
Simplify _PyStaticType_ClearWeakRefs
mpage
committed
cdb9290
Copy full SHA for cdb9290
Simplify get_or_create_weakref
mpage
committed
c93c336
Copy full SHA for c93c336
Add _PyWeakref_IsDead
mpage
committed
0366f01
Copy full SHA for 0366f01
Remove TODO
Show description for 3e135e4
mpage
committed
3e135e4
Copy full SHA for 3e135e4
Fix formatting
mpage
committed
dbf7c58
Copy full SHA for dbf7c58

Commits on Apr 8, 2024

Update Python/pystate.c
Show description for 73466bf

colesbury
and
erlend-aasland
authored
73466bf
Copy full SHA for 73466bf