gh-111926: Simplify weakref creation logic#116843
Merged
colesbury merged 2 commits intoMar 15, 2024
python:mainpython/cpython:mainfrom
mpage:gh-111926-simplify-weakref-creationmpage/cpython:gh-111926-simplify-weakref-creationCopy head branch name to clipboard
Merged
gh-111926: Simplify weakref creation logic#116843colesbury merged 2 commits intopython:mainpython/cpython:mainfrom mpage:gh-111926-simplify-weakref-creationmpage/cpython:gh-111926-simplify-weakref-creationCopy head branch name to clipboard
colesbury merged 2 commits into
python:mainpython/cpython:mainfrom
mpage:gh-111926-simplify-weakref-creationmpage/cpython:gh-111926-simplify-weakref-creationCopy head branch name to clipboard
Conversation
Since 3.12 allocating a GC object cannot immediately trigger GC. This allows us to simplify the logic for creating the canonical callback-less weakref.
Contributor
Author
|
The CIFuzz (memory) failure is unrelated to this PR. It's failing in the same way on other PRs and likely main. |
colesbury
approved these changes
Mar 15, 2024
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Mar 20, 2024
Since 3.12, allocating a GC object cannot immediately trigger GC. This allows us to simplify the logic for creating the canonical callback-less weakref.
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
Since 3.12, allocating a GC object cannot immediately trigger GC. This allows us to simplify the logic for creating the canonical callback-less weakref.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Since 3.12, allocating a GC object cannot immediately trigger GC. This allows us to simplify the logic for creating the canonical callback-less weakref.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 3.12 allocating a GC object cannot immediately trigger GC. This allows us to simplify the logic for creating the canonical callback-less weakref.