bpo-35582: Inline arguments tuple unpacking in handwritten code.#11524
Merged
serhiy-storchaka merged 3 commits intoJan 12, 2019
python:masterpython/cpython:masterfrom
serhiy-storchaka:inline-arg-tuple-unpackserhiy-storchaka/cpython:inline-arg-tuple-unpackCopy head branch name to clipboard
Merged
bpo-35582: Inline arguments tuple unpacking in handwritten code.#11524serhiy-storchaka merged 3 commits intopython:masterpython/cpython:masterfrom serhiy-storchaka:inline-arg-tuple-unpackserhiy-storchaka/cpython:inline-arg-tuple-unpackCopy head branch name to clipboard
serhiy-storchaka merged 3 commits into
python:masterpython/cpython:masterfrom
serhiy-storchaka:inline-arg-tuple-unpackserhiy-storchaka/cpython:inline-arg-tuple-unpackCopy head branch name to clipboard
Conversation
Inline PyArg_UnpackTuple() and _PyArg_UnpackStack() in performance critical code in the builtins and operator modules.
Member
Author
|
This PR rewrites again some of code changed in #11435. It looks now simpler but has the same performance. |
vstinner
reviewed
Jan 11, 2019
vstinner
approved these changes
Jan 11, 2019
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM but please keep "w" variable in builtin_iter() as I proposed in a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline PyArg_UnpackTuple() and _PyArg_UnpackStack() in performance
critical code in the builtins and operator modules.
https://bugs.python.org/issue35582