bpo-35641: IDLE - calltip not properly formatted if no docstring by eamanu · Pull Request #11415 · python/cpython

eamanu · Jan 2, 2019

bpo-35641: IDLE: calltips not properly formatted for functions without doc-strings

https://bugs.python.org/issue35641

taleinat

Other than my inline comment, two more things:

Add a test for this bug. It should fail without the fix and pass with the fix.
Add a NEWS entry. The easiest way to do so is to follow the "Details" link next to the failing "bedevere/news" check near the bottom of this page, which will lead you to the "blurb-it" tool.

bedevere-bot · Jan 2, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

remilapeyre

Thanks for your contribution!

When you write a commit message, make it more descriptive about what the commit does, it's very important when diving into git log, here are some tips about commit messages: https://devguide.python.org/pullrequest/#making-good-commits

You need to use blurb add or create manually an entry to Misc/NEWS.

Please add some test to your pull request :)

remove debug line

eamanu · Jan 2, 2019

Thanks for your comments. I will push tests

terryjreedy

What tal said. Add at least one test and a blurb file. I will likely edit whatever you write before merging, so don't agonize over the wording. But with a file, I can do so in the online pencil editor.

terryjreedy · Jan 3, 2019

Tal, since our change requests were identical, I will merge this when CI passes.

miss-islington · Jan 3, 2019

Thanks @eamanu for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

bedevere-bot · Jan 3, 2019

GH-11420 is a backport of this pull request to the 3.7 branch.

…-11415) (cherry picked from commit ab54b9a) Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>

(cherry picked from commit ab54b9a) Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>

miss-islington · Jan 3, 2019

Thanks @eamanu for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington · Jan 3, 2019

Sorry, @eamanu and @terryjreedy, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ab54b9a130c88f708077c2ef6c4963b632c132b3 3.7

miss-islington · Jan 3, 2019

Thanks @eamanu for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington · Jan 3, 2019

Sorry, @eamanu and @terryjreedy, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ab54b9a130c88f708077c2ef6c4963b632c132b3 3.7

taleinat · Jan 3, 2019

Sorry for the noise; both Terry and I added the "needs backport to 3.7", which caused the second backport attempt to fail.

terryjreedy · Jan 3, 2019

Better than neither of us ;-). Part of the problem was that the robots + GitHub were really slow in posting anything, so I removed and re-added the label after the backport has been done.

terryjreedy · Jan 9, 2019

I just noticed that the blurb was put in the Library directory instead of the Idle directory. #11479 moves it.

Fix bpo-35641

72ecc7a

eamanu requested a review from terryjreedy as a code owner January 2, 2019 19:43

the-knights-who-say-ni added the CLA signed label Jan 2, 2019

bedevere-bot added the awaiting review label Jan 2, 2019

eamanu changed the title ~~Fix bpo-35641: IDLE: calltips not properly formatted for functions without doc-strings~~ bpo-35641: IDLE: calltips not properly formatted for functions without doc-strings Jan 2, 2019

terryjreedy self-assigned this Jan 2, 2019

terryjreedy changed the title ~~bpo-35641: IDLE: calltips not properly formatted for functions without doc-strings~~ bpo-35641: IDLE - calltip not properly formatted if no docstring Jan 2, 2019

taleinat requested changes Jan 2, 2019

View reviewed changes

Comment thread Lib/idlelib/calltip.py Outdated

bedevere-bot removed the awaiting review label Jan 2, 2019

bedevere-bot added the awaiting changes label Jan 2, 2019

remilapeyre suggested changes Jan 2, 2019

View reviewed changes

Comment thread Lib/idlelib/calltip.py Outdated

terryjreedy reviewed Jan 2, 2019

View reviewed changes

Comment thread Lib/idlelib/calltip.py Outdated

Update calltip.py

3ff0b60

remove debug line

terryjreedy requested changes Jan 2, 2019

View reviewed changes

terryjreedy added needs backport to 3.7 type-bug An unexpected behavior, bug, or error labels Jan 2, 2019

eamanu and others added 2 commits January 2, 2019 22:15

Adding test case and NEWS

ca3a75a

Update 2019-01-02-22-15-01.bpo-35641.QEaANl.rst

46101b8

terryjreedy approved these changes Jan 3, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels Jan 3, 2019

terryjreedy added 2 commits January 3, 2019 01:21

Merge remote-tracking branch 'origin/master' into pr_11415

814e97a

Add Emmanuel Arias to misc/acks.

ebe6836

terryjreedy merged commit ab54b9a into python:master Jan 3, 2019

bedevere-bot removed the awaiting merge label Jan 3, 2019

bedevere-bot removed the needs backport to 3.7 label Jan 3, 2019

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 3, 2019

bpo-35641: IDLE - format calltip properly when no docstring (pythonGH…

0dc00ab

…-11415) (cherry picked from commit ab54b9a) Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>

miss-islington added a commit that referenced this pull request Jan 3, 2019

bpo-35641: IDLE - format calltip properly when no docstring (GH-11415)

3c83cb7

(cherry picked from commit ab54b9a) Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>

terryjreedy added the needs backport to 3.7 label Jan 3, 2019

terryjreedy added type-bug An unexpected behavior, bug, or error needs backport to 3.7 and removed needs backport to 3.7 type-bug An unexpected behavior, bug, or error labels Jan 3, 2019

taleinat removed the needs backport to 3.7 label Jan 3, 2019

eamanu deleted the fix35641 branch January 3, 2019 12:11

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

eamanu commented Jan 2, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taleinat left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Jan 2, 2019

Uh oh!

remilapeyre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

eamanu commented Jan 2, 2019

Uh oh!

terryjreedy left a comment

Choose a reason for hiding this comment

Uh oh!

terryjreedy commented Jan 3, 2019

Uh oh!

miss-islington commented Jan 3, 2019

Uh oh!

bedevere-bot commented Jan 3, 2019

Uh oh!

miss-islington commented Jan 3, 2019

Uh oh!

miss-islington commented Jan 3, 2019

Uh oh!

miss-islington commented Jan 3, 2019

Uh oh!

miss-islington commented Jan 3, 2019

Uh oh!

taleinat commented Jan 3, 2019

Uh oh!

terryjreedy commented Jan 3, 2019

Uh oh!

terryjreedy commented Jan 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

eamanu commented Jan 2, 2019 •

edited by bedevere-bot

Loading

taleinat left a comment •

edited

Loading