Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-113299: Create libclinic package#113309

Closed
vstinner wants to merge 1 commit into
python:mainpython/cpython:mainfrom
vstinner:libclinic_convertersvstinner/cpython:libclinic_convertersCopy head branch name to clipboard
Closed

gh-113299: Create libclinic package#113309
vstinner wants to merge 1 commit into
python:mainpython/cpython:mainfrom
vstinner:libclinic_convertersvstinner/cpython:libclinic_convertersCopy head branch name to clipboard

Conversation

@vstinner

@vstinner vstinner commented Dec 20, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member
  • Create Tools/clinic/libclinic/ package.
  • Move cpp.py to libclinic.
  • Create libclinic.utils.

@vstinner
pythongh-113299: Create libclinic package
b58b260 
* Create Tools/clinic/libclinic/ package.
* Move cpp.py to libclinic.
* Create libclinic.utils.
@bedevere-app bedevere-app Bot mentioned this pull request Dec 20, 2023
Closed
@vstinner

vstinner commented Dec 20, 2023

Copy link
Copy Markdown
Member Author

@erlend-aasland @AlexWaygood @corona10: Ok, here is first minimum step to create a new package for Argument Clinic code.

AlexWaygood
AlexWaygood reviewed Dec 20, 2023
View reviewed changes
Comment thread Tools/clinic/libclinic/utils.py


# Clinic instance
clinic: 'Clinic' | None = None

@AlexWaygood AlexWaygood Dec 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR feels like it only does my least favourite thing about your other PR :// #113299 (comment)

erlend-aasland
erlend-aasland reviewed Dec 20, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py

global clinic
clinic = self
utils.clinic = self

@erlend-aasland erlend-aasland Dec 20, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, putting a global from one file into another file is not a good idea.

@vstinner

vstinner commented Dec 20, 2023

Copy link
Copy Markdown
Member Author

@erlend-aasland:

IMO, putting a global from one file into another file is not a good idea.

I don't have the bandwidth right now to move this global variable. Adding utils.clinic variable is a temporary solution until someone can spend time to work on it. I gave on my latest attempt to partially fix the issue since nobody was available to review my work: #110984

Apparently, it's a requirement for @AlexWaygood and @erlend-aasland so I prefer to close this PR for now.

@vstinner vstinner closed this Dec 20, 2023
@erlend-aasland erlend-aasland mentioned this pull request Dec 20, 2023
Closed
@vstinner vstinner deleted the libclinic_converters branch December 20, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

@AlexWaygood AlexWaygood AlexWaygood left review comments

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @erlend-aasland @AlexWaygood
Morty Proxy This is a proxified and sanitized view of the page, visit original site.