Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-112205: Update textio module to use @getter as possible.#113095

Merged
corona10 merged 1 commit into
python:mainpython/cpython:mainfrom
corona10:gh-112205-textcorona10/cpython:gh-112205-textCopy head branch name to clipboard
Dec 14, 2023
Merged

gh-112205: Update textio module to use @getter as possible.#113095
corona10 merged 1 commit into
python:mainpython/cpython:mainfrom
corona10:gh-112205-textcorona10/cpython:gh-112205-textCopy head branch name to clipboard

Conversation

@corona10

@corona10 corona10 commented Dec 14, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Dec 14, 2023
Closed
@corona10

corona10 commented Dec 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

cpython/Modules/_io/textio.c

Lines 181 to 186 in 384d6c1

static PyGetSetDef textiobase_getset[] = {
{"encoding", (getter)textiobase_encoding_get, NULL, textiobase_encoding_doc},
{"newlines", (getter)textiobase_newlines_get, NULL, textiobase_newlines_doc},
{"errors", (getter)textiobase_errors_get, NULL, textiobase_errors_doc},
{NULL}
};

Will be updated with separate PR: Need AC changes :)

@corona10 corona10 enabled auto-merge (squash) December 14, 2023 10:13
@corona10 corona10 merged commit 23a5711 into python:main Dec 14, 2023
@corona10 corona10 deleted the gh-112205-text branch December 15, 2023 02:48
corona10 added a commit to corona10/cpython that referenced this pull request Dec 15, 2023
@corona10
pythongh-112205: Update textio module to use @getter as possible. (p…
daa8577 
…ythongh-113095)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@corona10 @aisk
pythongh-112205: Update textio module to use @getter as possible. (p…
3072202 
…ythongh-113095)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@corona10 @Glyphack
pythongh-112205: Update textio module to use @getter as possible. (p…
70bfefd 
…ythongh-113095)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@colesbury colesbury Awaiting requested review from colesbury

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@corona10 @erlend-aasland
Morty Proxy This is a proxified and sanitized view of the page, visit original site.