Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

GH-111520: Add back the operand local#111813

Merged
brandtbucher merged 2 commits into
python:mainpython/cpython:mainfrom
brandtbucher:local-operandbrandtbucher/cpython:local-operandCopy head branch name to clipboard
Nov 14, 2023
Merged

GH-111520: Add back the operand local#111813
brandtbucher merged 2 commits into
python:mainpython/cpython:mainfrom
brandtbucher:local-operandbrandtbucher/cpython:local-operandCopy head branch name to clipboard

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Nov 7, 2023

Copy link
Copy Markdown
Member

#111428 removed the operand local variable from the interpreter as part of a larger change. This adds it back, since the additional indirection makes tier two development more complicated.

@brandtbucher brandtbucher added performance Performance or resource usage skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Nov 7, 2023
@brandtbucher brandtbucher self-assigned this Nov 7, 2023
@brandtbucher brandtbucher changed the title GH-11520: Add back the operand local GH-111520: Add back the operand local Nov 7, 2023

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but let's wait to see how this interacts with @mdboom's #111794 (fix for PGO on Windows).

@brandtbucher brandtbucher merged commit 31ad7e0 into python:main Nov 14, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.