Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-110088: Fix asyncio test_prompt_cancellation()#110157

Merged
vstinner merged 1 commit into
python:mainpython/cpython:mainfrom
vstinner:asyncio_timeouts2vstinner/cpython:asyncio_timeouts2Copy head branch name to clipboard
Sep 30, 2023
Merged

gh-110088: Fix asyncio test_prompt_cancellation()#110157
vstinner merged 1 commit into
python:mainpython/cpython:mainfrom
vstinner:asyncio_timeouts2vstinner/cpython:asyncio_timeouts2Copy head branch name to clipboard

Conversation

@vstinner

@vstinner vstinner commented Sep 30, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Don't measure the CI performance: don't test the maximum elapsed time. The check failed on a slow CI.

@vstinner
pythongh-110088: Fix asyncio test_prompt_cancellation()
e74fa4e 
Don't measure the CI performance: don't test the maximum elapsed
time. The check failed on a slow CI.
@vstinner vstinner added tests Tests in the Lib/test dir topic-asyncio labels Sep 30, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 30, 2023
Closed
@vstinner vstinner added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 30, 2023
@vstinner

vstinner commented Sep 30, 2023

Copy link
Copy Markdown
Member Author

The test failed on GHA macOS:

FAIL: test_prompt_cancellation (test.test_asyncio.test_events.KqueueEventLoopTests.test_prompt_cancellation)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/runner/work/cpython/cpython/Lib/test/test_asyncio/test_events.py", line 1701, in test_prompt_cancellation
    self.assertLess(elapsed, 0.1)
AssertionError: 0.15447740299987345 not less than 0.1

build: https://github.com/python/cpython/actions/runs/6364342183/job/17280567179?pr=110148

@vstinner vstinner merged commit c62b49e into python:main Sep 30, 2023
@vstinner vstinner deleted the asyncio_timeouts2 branch September 30, 2023 20:40
@miss-islington

miss-islington commented Sep 30, 2023

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2023
@vstinner @miss-islington
pythongh-110088: Fix asyncio test_prompt_cancellation() (pythonGH-110157
6c9a357 
)

Don't measure the CI performance: don't test the maximum elapsed
time. The check failed on a slow CI.
(cherry picked from commit c62b49e)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

bedevere-app Bot commented Sep 30, 2023

Copy link
Copy Markdown

GH-110158 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 30, 2023
@bedevere-app

bedevere-app Bot commented Sep 30, 2023

Copy link
Copy Markdown

GH-110159 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Sep 30, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2023
@vstinner @miss-islington
pythongh-110088: Fix asyncio test_prompt_cancellation() (pythonGH-110157
39d2f9c 
)

Don't measure the CI performance: don't test the maximum elapsed
time. The check failed on a slow CI.
(cherry picked from commit c62b49e)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Sep 30, 2023
@miss-islington @vstinner
[3.11] gh-110088: Fix asyncio test_prompt_cancellation() (GH-110157) (#…
446c81c 
…110159)

gh-110088: Fix asyncio test_prompt_cancellation() (GH-110157)

Don't measure the CI performance: don't test the maximum elapsed
time. The check failed on a slow CI.
(cherry picked from commit c62b49e)

Co-authored-by: Victor Stinner <vstinner@python.org>
Yhg1s pushed a commit that referenced this pull request Oct 2, 2023
@miss-islington @vstinner
[3.12] gh-110088: Fix asyncio test_prompt_cancellation() (GH-110157) (#…
ce332aa 
…110158)

gh-110088: Fix asyncio test_prompt_cancellation() (GH-110157)

Don't measure the CI performance: don't test the maximum elapsed
time. The check failed on a slow CI.
(cherry picked from commit c62b49e)

Co-authored-by: Victor Stinner <vstinner@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-110088: Fix asyncio test_prompt_cancellation() (python#110157)
6a81301 
Don't measure the CI performance: don't test the maximum elapsed
time. The check failed on a slow CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @miss-islington
Morty Proxy This is a proxified and sanitized view of the page, visit original site.