[3.11] gh-109974: Fix threading lock_tests race conditions (GH-110057)#110063
Closed
miss-islington wants to merge 1 commit into
python:3.11python/cpython:3.11from
miss-islington:backport-4e356ad-3.11miss-islington/cpython:backport-4e356ad-3.11Copy head branch name to clipboard
Closed
[3.11] gh-109974: Fix threading lock_tests race conditions (GH-110057)#110063miss-islington wants to merge 1 commit intopython:3.11python/cpython:3.11from miss-islington:backport-4e356ad-3.11miss-islington/cpython:backport-4e356ad-3.11Copy head branch name to clipboard
miss-islington wants to merge 1 commit into
python:3.11python/cpython:3.11from
miss-islington:backport-4e356ad-3.11miss-islington/cpython:backport-4e356ad-3.11Copy head branch name to clipboard
Conversation
…10057) Fix race conditions in test_threading lock tests. Wait until a condition is met rather than using time.sleep() with a hardcoded number of seconds. * Replace sleeping loops with support.sleeping_retry() which raises an exception on timeout. * Add wait_threads_blocked(nthread) which computes a sleep depending on the number of threads. Remove _wait() function. * test_set_and_clear(): use a way longer Event.wait() timeout. * BarrierTests.test_repr(): wait until the 2 threads are waiting for the barrier. Use a way longer timeout for Barrier.wait() timeout. * test_thread_leak() no longer needs to count len(threading.enumerate()): Bunch uses threading_helper.wait_threads_exit() internally which does it in wait_for_finished(). * Add BaseLockTests.wait_phase() which implements a timeout. test_reacquire() and test_recursion_count() use wait_phase(). (cherry picked from commit 4e356ad) Co-authored-by: Victor Stinner <vstinner@python.org>
This was referenced Sep 29, 2023
Member
|
Oh, tests fail with: I will wait until changes are backported to 3.12 to backport these changes properly to 3.11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix race conditions in test_threading lock tests. Wait until a
condition is met rather than using time.sleep() with a hardcoded
number of seconds.
an exception on timeout.
on the number of threads. Remove _wait() function.
the barrier. Use a way longer timeout for Barrier.wait() timeout.
len(threading.enumerate()): Bunch uses
threading_helper.wait_threads_exit() internally which does it in
wait_for_finished().
test_reacquire() and test_recursion_count() use wait_phase().
(cherry picked from commit 4e356ad)
Co-authored-by: Victor Stinner vstinner@python.org