bpo-35376: Fix modulefinder skipping some nested modules#10894
Closed
rdb wants to merge 1 commit into
Closed
Conversation
|
PRs attempting to merge a maintenance branch into the master branch are deemed to be spam and automatically closed. If you were attempting to report a bug, please go to bugs.python.org; see devguide.python.org for further instruction as needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If modulefinder finds a nested module import (eg. 'import a.b.c') while there is a top-level module with the same name (eg. 'c') that failed to import and got added to the badmodules list, it will skip it entirely without even trying to import it.
The right thing to do is clearly to check it by fqname in the badmodules dict since that's also what it expects in other locations.
Should I make additional PRs for other branches or is this OK as-is?
https://bugs.python.org/issue35376
https://bugs.python.org/issue35376