gh-108455: peg_generator: make the mypy config slightly stricter#108627
Merged
AlexWaygood merged 4 commits intoAug 29, 2023
python:mainpython/cpython:mainfrom
AlexWaygood:peg-mypy-stricterAlexWaygood/cpython:peg-mypy-stricterCopy head branch name to clipboard
Merged
gh-108455: peg_generator: make the mypy config slightly stricter#108627AlexWaygood merged 4 commits intopython:mainpython/cpython:mainfrom AlexWaygood:peg-mypy-stricterAlexWaygood/cpython:peg-mypy-stricterCopy head branch name to clipboard
AlexWaygood merged 4 commits into
python:mainpython/cpython:mainfrom
AlexWaygood:peg-mypy-stricterAlexWaygood/cpython:peg-mypy-stricterCopy head branch name to clipboard
Conversation
sobolevn
approved these changes
Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This picks some low-hanging fruit when it comes to the mypy config, enabling various stricter settings that don't require large code changes:
--no-explicit-reexporttruthy-boolandignore-without-codeerror codes--warn-unreachablecan't yet be enabled. (It would take several code changes before we could enable it; it's deferred for now.)mypyonTools/peg_generator#108455