Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-108494: AC supports pos-only args in limited C API#108498

Merged
vstinner merged 1 commit into
python:mainpython/cpython:mainfrom
vstinner:ac_pos_limitedvstinner/cpython:ac_pos_limitedCopy head branch name to clipboard
Aug 25, 2023
Merged

gh-108494: AC supports pos-only args in limited C API#108498
vstinner merged 1 commit into
python:mainpython/cpython:mainfrom
vstinner:ac_pos_limitedvstinner/cpython:ac_pos_limitedCopy head branch name to clipboard

Conversation

@vstinner

@vstinner vstinner commented Aug 25, 2023

Copy link
Copy Markdown
Member

AC now checks for "#define Py_LIMITED_API" pattern to use the limited C API.

AC now checks for "#define Py_LIMITED_API" pattern to use the limited
C API.
@vstinner vstinner merged commit 86bc9e3 into python:main Aug 25, 2023
@vstinner vstinner deleted the ac_pos_limited branch August 25, 2023 22:39
Comment thread Tools/clinic/clinic.py
{parse_arguments}))
goto exit;
""", indent=4)]
argname_fmt = 'args[%d]'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not correct. In best case it is unused.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since AC and parsing arguments are complex, I propose to implement incrementally the limited C API. I'm not sure that I get your comment, when is it unused? Do you want to propose a fix?

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner, would you be able to add some documentation for this change to https://docs.python.org/3/howto/clinic.html? It would be useful information for users of Argument Clinic to know that they can generate code that only uses the limited C API by adding #define Py_LIMITED_API to a file

@vstinner

Copy link
Copy Markdown
Member Author

@vstinner, would you be able to add some documentation for this change to https://docs.python.org/3/howto/clinic.html? It would be useful information for users of Argument Clinic to know that they can generate code that only uses the limited C API by adding #define Py_LIMITED_API to a file

I wrote PR #108584 to document the Limited C API feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.