Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-105539: Fix ResourceWarning from unclosed SQLite connection in ClosedCurTests.#108360

Merged
erlend-aasland merged 1 commit into
python:mainpython/cpython:mainfrom
felixxm:gh-105539-resource-warningfelixxm/cpython:gh-105539-resource-warningCopy head branch name to clipboard
Aug 23, 2023
Merged

gh-105539: Fix ResourceWarning from unclosed SQLite connection in ClosedCurTests.#108360
erlend-aasland merged 1 commit into
python:mainpython/cpython:mainfrom
felixxm:gh-105539-resource-warningfelixxm/cpython:gh-105539-resource-warningCopy head branch name to clipboard

Conversation

@felixxm

@felixxm felixxm commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

Comment thread Lib/test/test_sqlite3/test_dbapi.py
@felixxm felixxm force-pushed the gh-105539-resource-warning branch 2 times, most recently from 0fe2b88 to 02851c2 Compare August 23, 2023 07:46
…in tests.

Follow up to 1a1bfc2.

Co-authored-by: Erlend E. Aasland <erlend@python.org>
auto-merge was automatically disabled August 23, 2023 09:21

Head branch was pushed to by a user without write access

@felixxm felixxm force-pushed the gh-105539-resource-warning branch from 02851c2 to 5c30ad3 Compare August 23, 2023 09:21
@felixxm

felixxm commented Aug 23, 2023

Copy link
Copy Markdown
Contributor Author

@erlend-aasland I found and fixed one more:

./python -m test -R : test_audit

@erlend-aasland

Copy link
Copy Markdown
Contributor

@erlend-aasland I found and fixed one more:

./python -m test -R : test_audit

Good catch!

@erlend-aasland erlend-aasland enabled auto-merge (squash) August 23, 2023 09:26
@erlend-aasland erlend-aasland merged commit 29bc616 into python:main Aug 23, 2023
@erlend-aasland

Copy link
Copy Markdown
Contributor

Thanks, Mariusz!

@felixxm felixxm deleted the gh-105539-resource-warning branch August 23, 2023 10:59
@bedevere-bot

This comment was marked as off-topic.

@bedevere-bot

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emit resource warning if sqlite3 fails to close the database

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.