[Docs] Fix Default Argument Values of xml.dom.minidom.Document.toprettyxml by e-kwsm · Pull Request #10814 · python/cpython

e-kwsm · Nov 30, 2018

The document is inconsistent with

Line 49 in 55e4980

def toprettyxml(self, indent="\t", newl="\n", encoding=None):

miss-islington · Nov 30, 2018

Thanks @e-kwsm for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington · Nov 30, 2018

Sorry, @e-kwsm and @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b7c2182604d5796b5af4c837991aa0b8c8a2d41f 3.7

miss-islington · Nov 30, 2018

Sorry, @e-kwsm and @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b7c2182604d5796b5af4c837991aa0b8c8a2d41f 3.6

miss-islington · Nov 30, 2018

Sorry, @e-kwsm and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b7c2182604d5796b5af4c837991aa0b8c8a2d41f 2.7

) (cherry picked from commit b7c2182)

…nGH-10814). (cherry picked from commit b7c2182) Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>

) (cherry picked from commit b7c2182)

…nGH-10814). (cherry picked from commit b7c2182) Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>

bedevere-bot · Nov 30, 2018

GH-10827 is a backport of this pull request to the 2.7 branch.

). (GH-10827) (cherry picked from commit b7c2182)

bedevere-bot · Dec 1, 2018

GH-10824 is a backport of this pull request to the 3.7 branch.

). (GH-10824) (cherry picked from commit b7c2182)

bedevere-bot · Dec 1, 2018

GH-10825 is a backport of this pull request to the 3.6 branch.

). (GH-10825) (cherry picked from commit b7c2182)

Escape the \t and \n. Follow up from python#10814. (cherry picked from commit 2d8f976) Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>

Escape the \t and \n. Follow up from #10814.

Escape the \t and \n. Follow up from python#10814.. (cherry picked from commit 2d8f976) Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>

Escape the \t and \n. Follow up from #10814. (cherry picked from commit 2d8f976) Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>

Escape the \t and \n. Follow up from #10814.. (cherry picked from commit 2d8f976) Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>

[Docs] Fix signature of xml.dom.minidom.Document.toprettyxml

ebfbb31

the-knights-who-say-ni added the CLA signed label Nov 30, 2018

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 30, 2018

e-kwsm changed the title ~~[Docs] Fix signature of xml.dom.minidom.Document.toprettyxml~~ [Docs] Fix Default Argument Values of xml.dom.minidom.Document.toprettyxml Nov 30, 2018

serhiy-storchaka approved these changes Nov 30, 2018

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Nov 30, 2018

serhiy-storchaka added needs backport to 3.6 skip issue skip news labels Nov 30, 2018

serhiy-storchaka merged commit b7c2182 into python:master Nov 30, 2018

bedevere-bot removed the awaiting merge label Nov 30, 2018

miss-islington assigned serhiy-storchaka Nov 30, 2018

e-kwsm added a commit to e-kwsm/cpython that referenced this pull request Nov 30, 2018

Fix signature of xml.dom.minidom.Document.toprettyxml(). (pythonGH-10814

d3c0749

) (cherry picked from commit b7c2182)

e-kwsm added a commit to e-kwsm/cpython that referenced this pull request Nov 30, 2018

[3.7] Fix signature of xml.dom.minidom.Document.toprettyxml(). (pytho…

ecf6654

…nGH-10814). (cherry picked from commit b7c2182) Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>

e-kwsm added a commit to e-kwsm/cpython that referenced this pull request Nov 30, 2018

Fix signature of xml.dom.minidom.Document.toprettyxml(). (pythonGH-10814

ddba5ee

) (cherry picked from commit b7c2182)

e-kwsm added a commit to e-kwsm/cpython that referenced this pull request Nov 30, 2018

[3.6] Fix signature of xml.dom.minidom.Document.toprettyxml(). (pytho…

946e8f7

…nGH-10814). (cherry picked from commit b7c2182) Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>

e-kwsm deleted the fix-docs-Node.toprettyxml branch November 30, 2018 16:23

e-kwsm added a commit to e-kwsm/cpython that referenced this pull request Nov 30, 2018

[2.7] Fix signature of xml.dom.minidom.Document.toprettyxml(). (pytho…

eae198f

…nGH-10814). (cherry picked from commit b7c2182) Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>

bedevere-bot removed the needs backport to 2.7 label Nov 30, 2018

serhiy-storchaka pushed a commit that referenced this pull request Dec 1, 2018

[2.7] Fix signature of xml.dom.minidom.Document.toprettyxml(). (GH-10814

dfd4a1d

). (GH-10827) (cherry picked from commit b7c2182)

bedevere-bot removed the needs backport to 3.7 label Dec 1, 2018

serhiy-storchaka pushed a commit that referenced this pull request Dec 1, 2018

[3.7] Fix signature of xml.dom.minidom.Document.toprettyxml(). (GH-10814

7da9755

). (GH-10824) (cherry picked from commit b7c2182)

bedevere-bot removed the needs backport to 3.6 label Dec 1, 2018

serhiy-storchaka pushed a commit that referenced this pull request Dec 1, 2018

[3.6] Fix signature of xml.dom.minidom.Document.toprettyxml(). (GH-10814

1e28daf

). (GH-10825) (cherry picked from commit b7c2182)

serhiy-storchaka removed their assignment Dec 5, 2018

e-kwsm mentioned this pull request Dec 5, 2018

Fix typo in xml.dom.minidom documentation #10956

Merged

miss-islington mentioned this pull request Dec 5, 2018

[2.7] Fix typo in xml.dom.minidom documentation (GH-10956) #10960

Merged

miss-islington pushed a commit that referenced this pull request Dec 5, 2018

Fix typo in xml.dom.minidom documentation (GH-10956)

2d8f976

Escape the \t and \n. Follow up from #10814.

Mariatta mentioned this pull request Dec 5, 2018

[3.7] Fix typo in xml.dom.minidom documentation (GH-10956) #10961

Merged

Mariatta mentioned this pull request Dec 5, 2018

[3.6] Fix typo in xml.dom.minidom documentation (GH-10956) #10962

Merged

miss-islington added a commit that referenced this pull request Dec 5, 2018

Fix typo in xml.dom.minidom documentation (GH-10956)

40ef5b7

Escape the \t and \n. Follow up from #10814. (cherry picked from commit 2d8f976) Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Docs] Fix Default Argument Values of xml.dom.minidom.Document.toprettyxml#10814

[Docs] Fix Default Argument Values of xml.dom.minidom.Document.toprettyxml#10814
serhiy-storchaka merged 1 commit into
python:masterpython/cpython:masterfrom
e-kwsm:fix-docs-Node.toprettyxmle-kwsm/cpython:fix-docs-Node.toprettyxmlCopy head branch name to clipboard

e-kwsm commented Nov 30, 2018

Uh oh!

miss-islington commented Nov 30, 2018

Uh oh!

miss-islington commented Nov 30, 2018

Uh oh!

miss-islington commented Nov 30, 2018

Uh oh!

miss-islington commented Nov 30, 2018

Uh oh!

bedevere-bot commented Nov 30, 2018

Uh oh!

bedevere-bot commented Dec 1, 2018

Uh oh!

bedevere-bot commented Dec 1, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

e-kwsm commented Nov 30, 2018

Uh oh!

miss-islington commented Nov 30, 2018

Uh oh!

miss-islington commented Nov 30, 2018

Uh oh!

miss-islington commented Nov 30, 2018

Uh oh!

miss-islington commented Nov 30, 2018

Uh oh!

bedevere-bot commented Nov 30, 2018

Uh oh!

bedevere-bot commented Dec 1, 2018

Uh oh!

bedevere-bot commented Dec 1, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants