Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-35284: Fix the error handling in the compiler's compiler_call()#10625

Merged
serhiy-storchaka merged 3 commits into
python:masterpython/cpython:masterfrom
ZackerySpytz:bpo-35284-compiler_call-bugZackerySpytz/cpython:bpo-35284-compiler_call-bugCopy head branch name to clipboard
Mar 22, 2019
Merged

bpo-35284: Fix the error handling in the compiler's compiler_call()#10625
serhiy-storchaka merged 3 commits into
python:masterpython/cpython:masterfrom
ZackerySpytz:bpo-35284-compiler_call-bugZackerySpytz/cpython:bpo-35284-compiler_call-bugCopy head branch name to clipboard

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Nov 20, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

compiler_call() needs to check if an error occurred during the
maybe_optimize_method_call() call.

https://bugs.python.org/issue35284

@ZackerySpytz
bpo-35284: Fix the error handling in the compiler's compiler_call()
85ac372 
compiler_call() needs to check if an error occurred during the
maybe_optimize_method_call() call.
brettcannon
brettcannon reviewed Nov 21, 2018
View reviewed changes
Comment thread Python/compile.c
@serhiy-storchaka serhiy-storchaka self-assigned this Nov 22, 2018
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 skip news labels Nov 22, 2018
@serhiy-storchaka

serhiy-storchaka commented Nov 22, 2018

Copy link
Copy Markdown
Member

Good catch! 👏 It is hard to notice this error. 🕵️‍♂️ How did you find it?

Do you mind to add a comment to maybe_optimize_method_call() about returning values? And please describe the error in more detail on the tracker.

@serhiy-storchaka

serhiy-storchaka commented Dec 9, 2018

Copy link
Copy Markdown
Member

Ping.

@brettcannon

brettcannon commented Dec 14, 2018

Copy link
Copy Markdown
Member

@ZackerySpytz just in case you didn't see the "ping" from Serhiy.

@ZackerySpytz

ZackerySpytz commented Dec 14, 2018

Copy link
Copy Markdown
Contributor Author

I saw it.

@ZackerySpytz

ZackerySpytz commented Mar 21, 2019

Copy link
Copy Markdown
Contributor Author

Hi, @serhiy-storchaka. Thank you for updating this PR. However, it seems that there is an error in the comment that you added. I will edit the comment.

@serhiy-storchaka serhiy-storchaka merged commit 97f5de0 into python:master Mar 22, 2019
@miss-islington

miss-islington commented Mar 22, 2019

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Mar 22, 2019

Copy link
Copy Markdown
Contributor

Sorry, @ZackerySpytz and @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 97f5de01adf993aee17dcd26e22ae421d013f372 3.7

ZackerySpytz added a commit to ZackerySpytz/cpython that referenced this pull request Mar 22, 2019
@ZackerySpytz
bpo-35284: Fix the error handling in the compiler's compiler_call(). (p…
ef2f8f1 
…ythonGH-10625)

compiler_call() needs to check if an error occurred during the
maybe_optimize_method_call() call.
(cherry picked from commit 97f5de0)
@bedevere-bot

bedevere-bot commented Mar 22, 2019

Copy link
Copy Markdown

GH-12496 is a backport of this pull request to the 3.7 branch.

@ZackerySpytz

ZackerySpytz commented Mar 22, 2019

Copy link
Copy Markdown
Contributor Author

Hi, @serhiy-storchaka. I've created a backport PR for 3.7.

serhiy-storchaka pushed a commit that referenced this pull request Mar 22, 2019
@ZackerySpytz @serhiy-storchaka
bpo-35284: Fix the error handling in the compiler's compiler_call(). (G…
bdb9c49 
…H-10625) (GH-12496)

compiler_call() needs to check if an error occurred during the
maybe_optimize_method_call() call.
(cherry picked from commit 97f5de0)
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZackerySpytz @serhiy-storchaka @brettcannon @miss-islington @bedevere-bot @the-knights-who-say-ni
Morty Proxy This is a proxified and sanitized view of the page, visit original site.