Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-106145: Make end_{lineno,col_offset} required on type_param nodes#106224

Merged
JelleZijlstra merged 2 commits into
python:mainpython/cpython:mainfrom
sobolevn:issue-106145sobolevn/cpython:issue-106145Copy head branch name to clipboard
Jun 30, 2023
Merged

gh-106145: Make end_{lineno,col_offset} required on type_param nodes#106224
JelleZijlstra merged 2 commits into
python:mainpython/cpython:mainfrom
sobolevn:issue-106145sobolevn/cpython:issue-106145Copy head branch name to clipboard

Conversation

@sobolevn

@sobolevn sobolevn commented Jun 29, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

I've also added test_type_alias.py to test_unparse to make sure that this new syntax works correctly with ast.unparse.

@sobolevn sobolevn requested a review from JelleZijlstra June 29, 2023 06:48
@bedevere-bot bedevere-bot mentioned this pull request Jun 29, 2023
Closed
lysnikolaou
lysnikolaou approved these changes Jun 29, 2023
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

JelleZijlstra
JelleZijlstra reviewed Jun 30, 2023
View reviewed changes
Comment thread Lib/test/test_unparse.py Outdated
@JelleZijlstra JelleZijlstra added the needs backport to 3.12 only security fixes label Jun 30, 2023
@JelleZijlstra JelleZijlstra self-assigned this Jun 30, 2023
@JelleZijlstra JelleZijlstra enabled auto-merge (squash) June 30, 2023 23:15
@JelleZijlstra JelleZijlstra merged commit 46c1097 into python:main Jun 30, 2023
@miss-islington

miss-islington commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 30, 2023
@sobolevn @miss-islington
pythongh-106145: Make end_{lineno,col_offset} required on `type_par…
36b296a 
…am` nodes (pythonGH-106224)

(cherry picked from commit 46c1097)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot

bedevere-bot commented Jun 30, 2023

Copy link
Copy Markdown

GH-106295 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 30, 2023
JelleZijlstra pushed a commit that referenced this pull request Jul 1, 2023
@miss-islington @sobolevn
[3.12] gh-106145: Make end_{lineno,col_offset} required on `type_pa…
0616c83 
…ram` nodes (GH-106224) (#106295)

gh-106145: Make `end_{lineno,col_offset}` required on `type_param` nodes (GH-106224)
(cherry picked from commit 46c1097)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
manosriram pushed a commit to manosriram/cpython that referenced this pull request Jul 1, 2023
@sobolevn @manosriram
pythongh-106145: Make end_{lineno,col_offset} required on `type_par…
ea9c4ff 
…am` nodes (python#106224)
jacobtylerwalls added a commit to jacobtylerwalls/typeshed that referenced this pull request Dec 26, 2023
@jacobtylerwalls
Make attributes required on AST type_param classes
2fbff73 
Refs python/cpython#106224
@jacobtylerwalls jacobtylerwalls mentioned this pull request Dec 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn @miss-islington @bedevere-bot @JelleZijlstra @lysnikolaou
Morty Proxy This is a proxified and sanitized view of the page, visit original site.