Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

GH-105588: Add missing error checks to some obj2ast_* converters#105589

Merged
brandtbucher merged 4 commits into
python:mainpython/cpython:mainfrom
brandtbucher:ast-error-handlingbrandtbucher/cpython:ast-error-handlingCopy head branch name to clipboard
Jun 15, 2023
Merged

GH-105588: Add missing error checks to some obj2ast_* converters#105589
brandtbucher merged 4 commits into
python:mainpython/cpython:mainfrom
brandtbucher:ast-error-handlingbrandtbucher/cpython:ast-error-handlingCopy head branch name to clipboard

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Jun 9, 2023

Copy link
Copy Markdown
Member

@brandtbucher brandtbucher added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 9, 2023
@brandtbucher brandtbucher self-assigned this Jun 9, 2023
@brandtbucher brandtbucher requested a review from isidentical as a code owner June 9, 2023 19:04
@furkanonder

Copy link
Copy Markdown
Contributor

CC: @isidentical

@brandtbucher brandtbucher merged commit a4056c8 into python:main Jun 15, 2023
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 15, 2023
pythonGH-105589)

(cherry picked from commit a4056c8)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
@bedevere-bot

Copy link
Copy Markdown

GH-105838 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 15, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 15, 2023
pythonGH-105589)

(cherry picked from commit a4056c8)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
@bedevere-bot

Copy link
Copy Markdown

GH-105839 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 15, 2023
brandtbucher added a commit that referenced this pull request Jun 15, 2023
…rs (GH-105838)

GH-105588: Add missing error checks to some obj2ast_* converters (GH-105589)
(cherry picked from commit a4056c8)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
brandtbucher added a commit that referenced this pull request Jun 15, 2023
…rs (GH-105839)

GH-105588: Add missing error checks to some obj2ast_* converters (GH-105589)
(cherry picked from commit a4056c8)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
carljm added a commit to carljm/cpython that referenced this pull request Jun 16, 2023
* main:
  pythongh-104799: PEP 695 backward compatibility for ast.unparse (python#105846)
  pythongh-105834: Add tests for calling `issubclass()` between two protocols (python#105835)
  CI: Remove docs build from Azure Pipelines (python#105823)
  pythongh-105844: Consistently use 'minor version' for X.Y versions (python#105851)
  Fix inaccuracies in "Assorted Topics" section of "Defining Extension Types" tutorial (python#104969)
  pythongh-105433: Add `pickle` tests for PEP695 (python#105443)
  bpo-44530: Document the change in MAKE_FUNCTION behavior (python#93189)
  pythonGH-103124: Multiline statement support for pdb (pythonGH-103125)
  pythonGH-105588: Add missing error checks to some obj2ast_* converters (pythonGH-105589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.