Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Docs fix-up: Remove references to ProcessPoolExecutor from asyncio-dev.rst#105543

Closed
eirrgang wants to merge 1 commit into
python:mainpython/cpython:mainfrom
eirrgang:patch-1eirrgang/cpython:patch-1Copy head branch name to clipboard
Closed

Docs fix-up: Remove references to ProcessPoolExecutor from asyncio-dev.rst#105543
eirrgang wants to merge 1 commit into
python:mainpython/cpython:mainfrom
eirrgang:patch-1eirrgang/cpython:patch-1Copy head branch name to clipboard

Conversation

@eirrgang

@eirrgang eirrgang commented Jun 9, 2023

Copy link
Copy Markdown
Contributor

ddd5f36 updated asyncio-eventloop.rst, but overlooked other references to using non-ThreadPoolExecutors with run_in_executor().

Ref bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor (GH-24540)


📚 Documentation preview 📚: https://cpython-previews--105543.org.readthedocs.build/

ddd5f36 updated asyncio-eventloop.rst, but overlooked other references to using non-ThreadPoolExecutors with `run_in_executor()`.

Ref bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor (pythonGH-24540)
@eirrgang

eirrgang commented Jun 9, 2023

Copy link
Copy Markdown
Contributor Author

I think I may have misinterpreted the update and the documentation. It looks like it is only set_default_executor for which ProcessPoolExecutor has been disallowed. A ProcessPoolExecutor instance can still be passed to run_in_executor() as an argument.

@eirrgang eirrgang closed this Jun 9, 2023
@eirrgang eirrgang deleted the patch-1 branch June 14, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.