gh-105431: Remove unused stuff from test_typing.NewTypeTests#105432
gh-105431: Remove unused stuff from test_typing.NewTypeTests#105432
test_typing.NewTypeTests#105432Conversation
|
🤖 New build scheduled with the buildbot fleet by @AlexWaygood for commit e444cfc 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
|
The refleak buildbots haven't run for some reason, and I would like to make sure we get a refleak buildbot run before merging this, since it's basically a revert of #27305, which was a PR to fix refleaks in Marking as do-not-merge until we've had a refleak buildbot run. |
|
Local result: |
I believe you, but I'd still like to make sure that we get the same results in CI before merging :) |
|
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit e444cfc 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks good assuming the buildbots eventually wake up
|
🤖 New build scheduled with the buildbot fleet by @AlexWaygood for commit e444cfc 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
AlexWaygood
left a comment
There was a problem hiding this comment.
The refleak buildbot results are finally in, and they look good. There's no failures in test_typing, just pre-existing refleaks in test_capi.
Thanks!
|
Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
GH-105489 is a backport of this pull request to the 3.12 branch. |
…ythonGH-105432) (cherry picked from commit 9d35a71) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
…GH-105432) (#105489) gh-105431: Remove unused stuff from `test_typing.NewTypeTests` (GH-105432) (cherry picked from commit 9d35a71) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
test_typing.NewTypeTestscan be improved #105431