Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-105431: Remove unused stuff from test_typing.NewTypeTests#105432

Merged
AlexWaygood merged 1 commit into
python:mainpython/cpython:mainfrom
sobolevn:issue-105431sobolevn/cpython:issue-105431Copy head branch name to clipboard
Jun 8, 2023
Merged

gh-105431: Remove unused stuff from test_typing.NewTypeTests#105432
AlexWaygood merged 1 commit into
python:mainpython/cpython:mainfrom
sobolevn:issue-105431sobolevn/cpython:issue-105431Copy head branch name to clipboard

Conversation

@sobolevn

@sobolevn sobolevn commented Jun 7, 2023

Copy link
Copy Markdown
Member

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @AlexWaygood for commit e444cfc 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jun 7, 2023
@AlexWaygood AlexWaygood added the needs backport to 3.12 only security fixes label Jun 7, 2023
@AlexWaygood

AlexWaygood commented Jun 7, 2023

Copy link
Copy Markdown
Member

The refleak buildbots haven't run for some reason, and I would like to make sure we get a refleak buildbot run before merging this, since it's basically a revert of #27305, which was a PR to fix refleaks in test_typing.

Marking as do-not-merge until we've had a refleak buildbot run.

@sobolevn

sobolevn commented Jun 7, 2023

Copy link
Copy Markdown
Member Author

Local result:

~/Desktop/cpython  issue-105431 ✔                                                      2 ⚠️
» ./python.exe -m test -R 5:5 -v test_typing > /dev/null
beginning 10 repetitions
1234567890
..........
                                                                                           
~/Desktop/cpython  issue-105431 ✔                                                         
» echo $?                                               
0

@AlexWaygood

Copy link
Copy Markdown
Member

Local result:

I believe you, but I'd still like to make sure that we get the same results in CI before merging :)

@JelleZijlstra JelleZijlstra added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jun 7, 2023
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit e444cfc 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jun 7, 2023

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming the buildbots eventually wake up

@AlexWaygood AlexWaygood added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jun 7, 2023
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @AlexWaygood for commit e444cfc 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jun 7, 2023

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refleak buildbot results are finally in, and they look good. There's no failures in test_typing, just pre-existing refleaks in test_capi.

Thanks!

@AlexWaygood AlexWaygood merged commit 9d35a71 into python:main Jun 8, 2023
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-105489 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2023
…ythonGH-105432)

(cherry picked from commit 9d35a71)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 8, 2023
AlexWaygood pushed a commit that referenced this pull request Jun 8, 2023
…GH-105432) (#105489)

gh-105431: Remove unused stuff from `test_typing.NewTypeTests` (GH-105432)
(cherry picked from commit 9d35a71)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir topic-typing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.