Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-103224: Resolve paths properly in test_sysconfig#103292

Merged
serhiy-storchaka merged 2 commits into
python:mainpython/cpython:mainfrom
artemmukhin:fix-test_sysconfig-python-symlinkartemmukhin/cpython:fix-test_sysconfig-python-symlinkCopy head branch name to clipboard
Feb 6, 2024
Merged

gh-103224: Resolve paths properly in test_sysconfig#103292
serhiy-storchaka merged 2 commits into
python:mainpython/cpython:mainfrom
artemmukhin:fix-test_sysconfig-python-symlinkartemmukhin/cpython:fix-test_sysconfig-python-symlinkCopy head branch name to clipboard

Conversation

@artemmukhin

@artemmukhin artemmukhin commented Apr 5, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Now running tests through a Python symlink no longer causes test_nt_venv_scheme and test_posix_venv_scheme to fail.

@hroncok Thank you for helping!

@artemmukhin @hroncok
pythonGH-103224: Resolve paths properly in test_sysconfig
51f0236 
To pass tests when executed through a Python symlink.

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
@artemmukhin artemmukhin requested a review from FFY00 as a code owner April 5, 2023 21:34
@bedevere-bot bedevere-bot mentioned this pull request Apr 5, 2023
Open
2 tasks
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Apr 5, 2023
serhiy-storchaka
serhiy-storchaka approved these changes Feb 6, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks safe.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) February 6, 2024 17:25
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 6, 2024
@serhiy-storchaka serhiy-storchaka changed the title GH-103224: Resolve paths properly in test_sysconfig gh-103224: Resolve paths properly in test_sysconfig Feb 6, 2024
@serhiy-storchaka serhiy-storchaka merged commit 71239d5 into python:main Feb 6, 2024
@miss-islington-app

miss-islington-app Bot commented Feb 6, 2024

Copy link
Copy Markdown

Thanks @artemmukhin for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2024
@artemmukhin @hroncok @miss-islington
pythongh-103224: Resolve paths properly in test_sysconfig (pythonGH-1…
bce6ca7 
…03292)

To pass tests when executed through a Python symlink.

(cherry picked from commit 71239d5)

Co-authored-by: Artem Mukhin <artem.m.mukhin@gmail.com>
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
@bedevere-app

bedevere-app Bot commented Feb 6, 2024

Copy link
Copy Markdown

GH-115100 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 6, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2024
@artemmukhin @hroncok @miss-islington
pythongh-103224: Resolve paths properly in test_sysconfig (pythonGH-1…
763af10 
…03292)

To pass tests when executed through a Python symlink.

(cherry picked from commit 71239d5)

Co-authored-by: Artem Mukhin <artem.m.mukhin@gmail.com>
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
@bedevere-app

bedevere-app Bot commented Feb 6, 2024

Copy link
Copy Markdown

GH-115101 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Feb 6, 2024
serhiy-storchaka pushed a commit that referenced this pull request Feb 7, 2024
@miss-islington @artemmukhin @hroncok
[3.12] gh-103224: Resolve paths properly in test_sysconfig (GH-103292) (
060c3ed 
GH-115100)

To pass tests when executed through a Python symlink.

(cherry picked from commit 71239d5)

Co-authored-by: Artem Mukhin <artem.m.mukhin@gmail.com>
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
serhiy-storchaka pushed a commit that referenced this pull request Feb 7, 2024
@miss-islington @artemmukhin @hroncok
[3.11] gh-103224: Resolve paths properly in test_sysconfig (GH-103292) (
3aa4418 
GH-115101)

To pass tests when executed through a Python symlink.

(cherry picked from commit 71239d5)

Co-authored-by: Artem Mukhin <artem.m.mukhin@gmail.com>
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@artemmukhin @hroncok @fsc-eriker
pythongh-103224: Resolve paths properly in test_sysconfig (pythonGH-1…
d0c42eb 
…03292)

To pass tests when executed through a Python symlink.

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artemmukhin @serhiy-storchaka @bedevere-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.