Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-103023: Add SyntaxError check in pdb's display command#103024

Merged
ambv merged 7 commits into
python:mainpython/cpython:mainfrom
gaogaotiantian:display-syntax-errorgaogaotiantian/cpython:display-syntax-errorCopy head branch name to clipboard
Mar 27, 2023
Merged

gh-103023: Add SyntaxError check in pdb's display command#103024
ambv merged 7 commits into
python:mainpython/cpython:mainfrom
gaogaotiantian:display-syntax-errorgaogaotiantian/cpython:display-syntax-errorCopy head branch name to clipboard

Conversation

@gaogaotiantian

@gaogaotiantian gaogaotiantian commented Mar 25, 2023

Copy link
Copy Markdown
Member

In this PR, extra stuff was cleaned up a bit:

  1. sys.exc_info() is no longer needed now that format_exception_only supported exception object directly.
  2. A clearer message is sent to the users when no expression is being displayed

Comment thread Lib/pdb.py Outdated
Comment thread Lib/pdb.py Outdated
Comment thread Lib/pdb.py Outdated
@ambv ambv merged commit 3606753 into python:main Mar 27, 2023
@gaogaotiantian gaogaotiantian deleted the display-syntax-error branch March 27, 2023 21:16
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.