Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-101446: Change repr of collections.OrderedDict#101661

Merged
rhettinger merged 4 commits into
python:mainpython/cpython:mainfrom
sobolevn:issue-101446sobolevn/cpython:issue-101446Copy head branch name to clipboard
Feb 8, 2023
Merged

gh-101446: Change repr of collections.OrderedDict#101661
rhettinger merged 4 commits into
python:mainpython/cpython:mainfrom
sobolevn:issue-101446sobolevn/cpython:issue-101446Copy head branch name to clipboard

Conversation

@sobolevn

@sobolevn sobolevn commented Feb 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Now it is:

>>> from collections import OrderedDict
>>> OrderedDict({1: 'a', 2: 'b'})
OrderedDict({1: 'a', 2: 'b'})

Openning this as a draft to see what tests will fail :)

@bedevere-bot bedevere-bot mentioned this pull request Feb 7, 2023
Closed
@sobolevn sobolevn marked this pull request as ready for review February 7, 2023 21:29
@sobolevn sobolevn requested a review from rhettinger as a code owner February 7, 2023 21:29
@rhettinger rhettinger merged commit 790ff6b into python:main Feb 8, 2023
@Gouvernathor

Gouvernathor commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

Out of curiosity, why not using super().repr() instead of recreating a whole new dict ? Wouldn't it save quite some time ?

@jacobtylerwalls jacobtylerwalls mentioned this pull request May 10, 2023
Closed
musicinmybrain added a commit to musicinmybrain/glymur that referenced this pull request Jul 11, 2023
@musicinmybrain
Adapt to OrderedDict repr change in Python 3.12
5cd1c93 
python/cpython#101661
@musicinmybrain musicinmybrain mentioned this pull request Jul 11, 2023
Closed
@jeertmans jeertmans mentioned this pull request Oct 23, 2023
Merged
1 task
@Linchin Linchin mentioned this pull request Dec 1, 2023
Merged
@XuehaiPan XuehaiPan mentioned this pull request Apr 4, 2024
Merged
12 tasks
@kounelisagis kounelisagis mentioned this pull request May 8, 2024
Merged
This was referenced Jul 12, 2024
Open
Open
@randomir randomir mentioned this pull request Dec 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn @Gouvernathor @pochmann @rhettinger @bedevere-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.