bpo-33710: Deprecate l*gettext() and related functions in the gettext module.#10139
Merged
serhiy-storchaka merged 7 commits intoOct 27, 2018
python:masterpython/cpython:masterfrom
serhiy-storchaka:deprecate-lgettextserhiy-storchaka/cpython:deprecate-lgettextCopy head branch name to clipboard
Merged
bpo-33710: Deprecate l*gettext() and related functions in the gettext module.#10139serhiy-storchaka merged 7 commits intopython:masterpython/cpython:masterfrom serhiy-storchaka:deprecate-lgettextserhiy-storchaka/cpython:deprecate-lgettextCopy head branch name to clipboard
serhiy-storchaka merged 7 commits into
python:masterpython/cpython:masterfrom
serhiy-storchaka:deprecate-lgettextserhiy-storchaka/cpython:deprecate-lgettextCopy head branch name to clipboard
Conversation
… module. They return encoded bytes and are Python 2 artifacts.
warsaw
requested changes
Oct 26, 2018
warsaw
left a comment
Member
There was a problem hiding this comment.
Looks great, but I have some wording suggestions, and one coding suggestion.
|
When you're done making the requested changes, leave the comment: |
Co-Authored-By: serhiy-storchaka <storchaka@gmail.com>
Co-Authored-By: serhiy-storchaka <storchaka@gmail.com>
Co-Authored-By: serhiy-storchaka <storchaka@gmail.com>
Co-Authored-By: serhiy-storchaka <storchaka@gmail.com>
Co-Authored-By: serhiy-storchaka <storchaka@gmail.com>
Member
Author
|
Thank you Barry! I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @warsaw: please review the changes made to this pull request. |
warsaw
approved these changes
Oct 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They return encoded bytes and are Python 2 artifacts.
https://bugs.python.org/issue33710