[3.6] bpo-35059, libmpdec: Add missing EXTINLINE in mpdecimal.h (GH-10128)#10134
Merged
miss-islington merged 1 commit intoOct 26, 2018
python:3.6python/cpython:3.6from
miss-islington:backport-3b1cba3-3.6miss-islington/cpython:backport-3b1cba3-3.6Copy head branch name to clipboard
Merged
[3.6] bpo-35059, libmpdec: Add missing EXTINLINE in mpdecimal.h (GH-10128)#10134miss-islington merged 1 commit intopython:3.6python/cpython:3.6from miss-islington:backport-3b1cba3-3.6miss-islington/cpython:backport-3b1cba3-3.6Copy head branch name to clipboard
miss-islington merged 1 commit into
python:3.6python/cpython:3.6from
miss-islington:backport-3b1cba3-3.6miss-islington/cpython:backport-3b1cba3-3.6Copy head branch name to clipboard
Conversation
…0128) Declare functions with EXTINLINE: * mpd_del() * mpd_uint_zero() * mpd_qresize() * mpd_qresize_zero() * mpd_minalloc() These functions are implemented with "inline" or "ALWAYS_INLINE", but declared without inline which cause linker error on Visual Studio in Debug mode when using /Ob1. (cherry picked from commit 3b1cba3) Co-authored-by: Victor Stinner <vstinner@redhat.com>
Contributor
Author
|
@vstinner: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declare functions with EXTINLINE:
These functions are implemented with "inline" or "ALWAYS_INLINE", but
declared without inline which cause linker error on Visual Studio in
Debug mode when using /Ob1.
(cherry picked from commit 3b1cba3)
Co-authored-by: Victor Stinner vstinner@redhat.com
https://bugs.python.org/issue35059