[3.6] bpo-35017, socketserver: don't accept request after shutdown (GH-9952)#10126
Merged
miss-islington merged 1 commit intoOct 26, 2018
python:3.6python/cpython:3.6from
miss-islington:backport-10cb376-3.6miss-islington/cpython:backport-10cb376-3.6Copy head branch name to clipboard
Merged
[3.6] bpo-35017, socketserver: don't accept request after shutdown (GH-9952)#10126miss-islington merged 1 commit intopython:3.6python/cpython:3.6from miss-islington:backport-10cb376-3.6miss-islington/cpython:backport-10cb376-3.6Copy head branch name to clipboard
miss-islington merged 1 commit into
python:3.6python/cpython:3.6from
miss-islington:backport-10cb376-3.6miss-islington/cpython:backport-10cb376-3.6Copy head branch name to clipboard
Conversation
…H-9952) Prior to this revision, after the shutdown of a `BaseServer`, the server accepted a last single request if it was sent between the server socket polling and the polling timeout. This can be problematic for instance for a server restart for which you do not want to interrupt the service, by not closing the listening socket during the restart. One request failed because of this behavior. Note that only one request failed, following requests were not accepted, as expected. (cherry picked from commit 10cb376) Co-authored-by: Denis Ledoux <be.ledoux.denis@gmail.com>
Contributor
Author
|
@beledouxdenis and @vstinner: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this revision, after the shutdown of a
BaseServer,the server accepted a last single request
if it was sent between the server socket polling
and the polling timeout.
This can be problematic for instance for a server restart
for which you do not want to interrupt the service,
by not closing the listening socket during the restart.
One request failed because of this behavior.
Note that only one request failed,
following requests were not accepted, as expected.
(cherry picked from commit 10cb376)
Co-authored-by: Denis Ledoux be.ledoux.denis@gmail.com
https://bugs.python.org/issue35017