gh-100540: Remove unnecessary '-DMACOSX' for ctypes on macOS#100542
Merged
zware merged 1 commit intoDec 28, 2022
python:mainpython/cpython:mainfrom
zware:remove_unnecessary_definezware/cpython:remove_unnecessary_defineCopy head branch name to clipboard
Merged
gh-100540: Remove unnecessary '-DMACOSX' for ctypes on macOS#100542zware merged 1 commit intopython:mainpython/cpython:mainfrom zware:remove_unnecessary_definezware/cpython:remove_unnecessary_defineCopy head branch name to clipboard
zware merged 1 commit into
python:mainpython/cpython:mainfrom
zware:remove_unnecessary_definezware/cpython:remove_unnecessary_defineCopy head branch name to clipboard
Conversation
The define was only used to protect a `#pragma clang diagnostic` setting, which is already better guarded by `__clang__` anwyay.
Member
Author
|
!buildbot .*mac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The define was only used to protect a
#pragma clang diagnosticsetting, which is already better guarded by
__clang__anwyay._ctypes/libffibuild, particularly on macOS #100540