gh-100540: Remove obsolete Modules/_ctypes/darwin/ dlfcn shim#100541
Merged
zware merged 1 commit intoDec 29, 2022
python:mainpython/cpython:mainfrom
zware:remove__ctypes_dlfcn_shimzware/cpython:remove__ctypes_dlfcn_shimCopy head branch name to clipboard
Merged
gh-100540: Remove obsolete Modules/_ctypes/darwin/ dlfcn shim#100541zware merged 1 commit intopython:mainpython/cpython:mainfrom zware:remove__ctypes_dlfcn_shimzware/cpython:remove__ctypes_dlfcn_shimCopy head branch name to clipboard
zware merged 1 commit into
python:mainpython/cpython:mainfrom
zware:remove__ctypes_dlfcn_shimzware/cpython:remove__ctypes_dlfcn_shimCopy head branch name to clipboard
Conversation
Member
Author
|
!buildbot macos |
Member
Author
|
!buildbot .*mac |
Member
|
Probably, this should be removed too: |
67d159c to
73b501e
Compare
Member
Author
Ah, thanks; I missed that one here, though I got the neighboring one in GH-100543. |
73b501e to
b2b2802
Compare
As far as I can tell, this hasn't been actually used since Mac OS X 10.2.
b2b2802 to
2404f50
Compare
ronaldoussoren
approved these changes
Dec 29, 2022
ronaldoussoren
left a comment
Contributor
There was a problem hiding this comment.
Patch looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell, this hasn't been actually used since Mac OS X 10.2.
_ctypes/libffibuild, particularly on macOS #100540