You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During error cases we may fail to decref mangled while using these ADDOP* and VISIT macros. As a result, we can extract the for loop's body into a subfunction that we check the return of and decref mangled if needed.
// NOTE: ref of mangled can be leaked on ADDOP* and VISIT macros due to early returns// fixing would require an overhaul of these macros
Bug report
Bug description:
Follow-up item from this PR: #146443 (review)
During error cases we may fail to decref mangled while using these
ADDOP*andVISITmacros. As a result, we can extract the for loop's body into a subfunction that we check the return of and decref mangled if needed.CPython versions tested on:
CPython main branch
Operating systems tested on:
Windows
Linked PRs
codegen_deferred_annotations_bodyto avoid missing decref ofmangled#148060