Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Refactor asyncio tools tests to use structures from _remote_debugging directly #143955

Copy link
Copy link
@johnslavik

Description

@johnslavik
Issue body actions

The asyncio tools use structures from the _remote_debugging module.

In tests we currently reimplement these structures:

FrameInfo = namedtuple('FrameInfo', ['funcname', 'filename', 'lineno'])
CoroInfo = namedtuple('CoroInfo', ['call_stack', 'task_name'])
TaskInfo = namedtuple('TaskInfo', ['task_id', 'task_name', 'coroutine_stack', 'awaited_by'])
AwaitedInfo = namedtuple('AwaitedInfo', ['thread_id', 'awaited_by'])

In GH-142394, the upstream structures from _remote_debugging were changed, but the reimplementations in the tests were not updated to match. This caused a regression from GH-143952 to sneak in.

Let's use structures from _remote_debugging directly, as it is currently done in test_external_inspection, to prevent any further unnoticed discrepancies.

cc @pablogsal

Linked PRs

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

testsTests in the Lib/test dirTests in the Lib/test dirtype-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.