Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Negative indexing in free-threading can access data that never lived at that index #130744

Copy link
Copy link
Closed as not planned
Closed as not planned
Negative indexing in free-threading can access data that never lived at that index#130744
Copy link
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)topic-free-threadingtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
@tom-pytel

Description

@tom-pytel
tom-pytel
opened on Mar 1, 2025
Issue body actions

Bug report

Bug description:

The place that negative indices for lists are offset currently in the free-threaded build can cause data to be returned that never actually resided at that offset (negatively speaking) if the list is modified during the access (either before or after the modification). Is this an issue?

cpython/Objects/listobject.c

Line 3581 in 5326c27

i += PyList_GET_SIZE(self);

Reproducer (it will happen eventually):

import re
import threading


def ins1(b, l):
    b.wait()
    l.insert(0, 'potato')

def get_secret(b, l):
    b.wait()
    assert l[-1] != 'super secret password'


def check(funcs, *args):
    barrier = threading.Barrier(len(funcs))
    thrds = []

    for func in funcs:
        thrd = threading.Thread(target=func, args=(barrier, *args))

        thrds.append(thrd)
        thrd.start()

    for thrd in thrds:
        thrd.join()


if __name__ == "__main__":
    while True:
        check([ins1] + [get_secret] * 10, ['super secret password', 'tomato'])

Output:

$ ./python ../check.py 
Exception in thread Thread-38474 (get_secret):
Traceback (most recent call last):
  File "/home/tom/work/cpython/free/cp/Lib/threading.py", line 1054, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/tom/work/cpython/free/cp/Lib/threading.py", line 996, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tom/work/cpython/free/cp/../check.py", line 11, in get_secret
    assert l[-1] != 'super secret password'
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError

CPython versions tested on:

3.14

Operating systems tested on:

Linux

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)topic-free-threadingtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      Morty Proxy This is a proxified and sanitized view of the page, visit original site.