Bug report
Bug description:
One of my PRs (#118283) started failing (https://github.com/python/cpython/actions/runs/8843882336?pr=118283) with this. Investigating, I can reproduce it locally on main, although I don't know why the CI passes on main.
OS: macOS Sonoma 14.4.1, M2.
To reproduce
git clone https://github.com/python/cpython
cd cpython
./configure --with-pydebug && make -j10
./python.exe Lib/test/test_repl.py
Actual result
.....F.
======================================================================
FAIL: test_no_memory (__main__.TestInteractiveInterpreter.test_no_memory)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/private/tmp/cpython/Lib/test/test_repl.py", line 86, in test_no_memory
self.assertIn(p.returncode, (1, 120))
~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: -6 not found in (1, 120)Printing output from the test:
Python 3.13.0a5+ (bisect/good-e16062dd3428a5846344e0a8c6ee2f352d34ce1b-1-gdf73179048:df73179048, A) [Clang 15.0.0 (clang-1500.3.9.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> >>> >>> Traceback (most recent call last):
File "<stdin>", line 1, in <module>
1/0
~^~
ZeroDivisionError: division by zero
>>> After the exception.
>>> object address : 0x102f8b9a0
object refcount : 3
object type : 0x102b831a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x102f8b930
object refcount : 3
object type : 0x102b831a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x102f8b9a0
object refcount : 3
object type : 0x102b831a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x102f8b930
object refcount : 3
object type : 0x102b831a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x102f8b9a0
object refcount : 3
object type : 0x102b831a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x102f8b930
object refcount : 3
object type : 0x102b831a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x102f8b9a0
object refcount : 3
object type : 0x102b831a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x102f8b930
object refcount : 3
object type : 0x102b831a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x102f8b9a0
object refcount : 3
object type : 0x102b831a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x102f8b930
object refcount : 3
object type : 0x102b831a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x102f8b9a0
object refcount : 3
object type : 0x102b831a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x102f8b930
object refcount : 3
object type : 0x102b831a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x102f8b9a0
object refcount : 3
object type : 0x102b831a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x102f8b930
object refcount : 3
object type : 0x102b831a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x102f8b9a0
object refcount : 3
object type : 0x102b831a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x102f8b930
object refcount : 3
object type : 0x102b831a8
object type name: MemoryError
object repr :
lost sys.stderr
Fatal Python error: _Py_Dealloc: Deallocator of type '_thread._localdummy' raised an exception
Python runtime state: finalizing (tstate=0x0000000102bf3c40)
Current thread 0x0000000201f77ac0 (most recent call first):
<no Python frame>
Expected result
It passes with v3.13.0a5, where output is:
Python 3.13.0a5 (tags/v3.13.0a5:076d169ebb, Apr 26 2024, 22:13:38) [Clang 15.0.0 (clang-1500.3.9.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> >>> >>> Traceback (most recent call last):
File "<stdin>", line 1, in <module>
1/0
~^~
ZeroDivisionError: division by zero
>>> After the exception.
>>> object address : 0x100f63a10
object refcount : 3
object type : 0x100b5f1a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x100f639a0
object refcount : 3
object type : 0x100b5f1a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x100f63a10
object refcount : 3
object type : 0x100b5f1a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x100f639a0
object refcount : 3
object type : 0x100b5f1a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x100f63a10
object refcount : 3
object type : 0x100b5f1a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x100f639a0
object refcount : 3
object type : 0x100b5f1a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x100f63a10
object refcount : 3
object type : 0x100b5f1a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x100f639a0
object refcount : 3
object type : 0x100b5f1a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x100f63a10
object refcount : 3
object type : 0x100b5f1a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x100f639a0
object refcount : 3
object type : 0x100b5f1a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x100f63a10
object refcount : 3
object type : 0x100b5f1a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x100f639a0
object refcount : 3
object type : 0x100b5f1a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x100f63a10
object refcount : 3
object type : 0x100b5f1a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x100f639a0
object refcount : 3
object type : 0x100b5f1a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x100f63a10
object refcount : 3
object type : 0x100b5f1a8
object type name: MemoryError
object repr :
lost sys.stderr
object address : 0x100f639a0
object refcount : 3
object type : 0x100b5f1a8
object type name: MemoryError
object repr :
lost sys.stderr
The main difference is the failure includes this:
Fatal Python error: _Py_Dealloc: Deallocator of type '_thread._localdummy' raised an exception
Python runtime state: finalizing (tstate=0x0000000102bf3c40)
Current thread 0x0000000201f77ac0 (most recent call first):
<no Python frame>
Bisecting
df7317904849a41d51db39d92c5d431a18e22637 is the first bad commit
commit df7317904849a41d51db39d92c5d431a18e22637
Author: mpage <mpage@meta.com>
Date: Mon Apr 8 07:58:38 2024 -0700
gh-111926: Make weakrefs thread-safe in free-threaded builds (#117168)
Most mutable data is protected by a striped lock that is keyed on the
referenced object's address. The weakref's hash is protected using the
weakref's per-object lock.
Note that this only affects free-threaded builds. Apart from some minor
refactoring, the added code is all either gated by `ifdef`s or is a no-op
(e.g. `Py_BEGIN_CRITICAL_SECTION`).
Include/cpython/weakrefobject.h | 8 +
Include/internal/pycore_interp.h | 7 +
Include/internal/pycore_object.h | 40 +-
Include/internal/pycore_pyatomic_ft_wrappers.h | 5 +
Include/internal/pycore_weakref.h | 73 +++-
Lib/test/test_sys.py | 8 +-
Lib/test/test_weakref.py | 19 +
Modules/_sqlite/blob.c | 5 +-
Modules/_sqlite/connection.c | 4 +-
Modules/_ssl.c | 13 +-
Modules/_ssl/debughelpers.c | 6 +-
Modules/_weakref.c | 42 +-
Modules/clinic/_weakref.c.h | 20 +-
Objects/dictobject.c | 8 +-
Objects/typeobject.c | 12 +-
Objects/weakrefobject.c | 537 ++++++++++++++-----------
Python/pystate.c | 9 +
17 files changed, 490 insertions(+), 326 deletions(-)
bisect found first bad commit
PR: #117168
Issue: #111926
The PR was merged three weeks ago and the CI is passing.
On my PR (https://github.com/python/cpython/actions/runs/8843882336?pr=118283), free-threaded builds pass, but regular ones fail. Ubuntu and macOS fail with:
AssertionError: -6 not found in (1, 120)
Windows with:
AssertionError: 3221225477 not found in (1, 120)
3221225477 seems to be 0xc0000005 STATUS_ACCESS_VIOLATION.
CPython versions tested on:
3.13
Operating systems tested on:
macOS
Linked PRs
Bug report
Bug description:
One of my PRs (#118283) started failing (https://github.com/python/cpython/actions/runs/8843882336?pr=118283) with this. Investigating, I can reproduce it locally on
main, although I don't know why the CI passes onmain.OS: macOS Sonoma 14.4.1, M2.
To reproduce
Actual result
Printing
outputfrom the test:Expected result
It passes with
v3.13.0a5, whereoutputis:The main difference is the failure includes this:
Bisecting
PR: #117168
Issue: #111926
The PR was merged three weeks ago and the CI is passing.
On my PR (https://github.com/python/cpython/actions/runs/8843882336?pr=118283), free-threaded builds pass, but regular ones fail. Ubuntu and macOS fail with:
Windows with:
3221225477 seems to be 0xc0000005
STATUS_ACCESS_VIOLATION.CPython versions tested on:
3.13
Operating systems tested on:
macOS
Linked PRs
test_list.ListTest.test_no_memoryunder trace refs build #130921