Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

A loop split between two hot executors never calls CHECK_EVAL_BREAKER() #117442

Copy link
Copy link
@gvanrossum

Description

@gvanrossum
Issue body actions

When a tight for loop without calls is turned into two traces that transfer directly to each other, it seems that CHECK_EVAL_BREAKER() is never called, and the loop won't be interruptible.

See faster-cpython/ideas#669 (comment), where @brandtbucher and I reasoned that this might occur in the nbody benchmark (when the max trace length is reduced to 400).

While we didn't observe the predicted speedup, we really do believe that in this case the thread is uninterruptible.

@markshannon Any thoughts?

Linked PRs

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.