python
diff --git a/‎Misc/NEWS.d/next/Core and Builtins/2023-10-02-23-17-08.gh-issue-110237._Xub0z.rst
Copy file name to clipboard
+1Lines changed: 1 addition & 0 deletions b/‎Misc/NEWS.d/next/Core and Builtins/2023-10-02-23-17-08.gh-issue-110237._Xub0z.rst
Copy file name to clipboard
+1Lines changed: 1 addition & 0 deletions
diff --git a/‎Python/ceval.c
Copy file name to clipboardExpand all lines: Python/ceval.c
+11-3Lines changed: 11 additions & 3 deletions b/‎Python/ceval.c
Copy file name to clipboardExpand all lines: Python/ceval.c
+11-3Lines changed: 11 additions & 3 deletions
@@ -0,0 +1 @@
+Fix missing error checks for calls to ``PyList_Append`` in ``_PyEval_MatchClass``.
@@ -489,7 +489,9 @@ match_class(PyThreadState *tstate, PyObject *subject, PyObject *type,
         }
         if (match_self) {
             // Easy. Copy the subject itself, and move on to kwargs.
-            PyList_Append(attrs, subject);
+            if (PyList_Append(attrs, subject) < 0) {
+                goto fail;
+            }
         }
         else {
             for (Py_ssize_t i = 0; i < nargs; i++) {
@@ -505,7 +507,10 @@ match_class(PyThreadState *tstate, PyObject *subject, PyObject *type,
                 if (attr == NULL) {
                     goto fail;
                 }
-                PyList_Append(attrs, attr);
+                if (PyList_Append(attrs, attr) < 0) {
+                    Py_DECREF(attr);
+                    goto fail;
+                }
                 Py_DECREF(attr);
             }
         }
@@ -518,7 +523,10 @@ match_class(PyThreadState *tstate, PyObject *subject, PyObject *type,
         if (attr == NULL) {
             goto fail;
         }
-        PyList_Append(attrs, attr);
+        if (PyList_Append(attrs, attr) < 0) {
+            Py_DECREF(attr);
+            goto fail;
+        }
         Py_DECREF(attr);
     }
     Py_SETREF(attrs, PyList_AsTuple(attrs));
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix missing error checks for calls to ``PyList_Append`` in ``_PyEval_MatchClass``.
Original file line number	Diff line number	Diff line change
`@@ -489,7 +489,9 @@ match_class(PyThreadState tstate, PyObject subject, PyObject *type,`
`489`	`489`	`}`
`490`	`490`	`if (match_self) {`
`491`	`491`	`// Easy. Copy the subject itself, and move on to kwargs.`
`492`		`- PyList_Append(attrs, subject);`
	`492`	`+ if (PyList_Append(attrs, subject) < 0) {`
	`493`	`+ goto fail;`
	`494`	`+ }`
`493`	`495`	`}`
`494`	`496`	`else {`
`495`	`497`	`for (Py_ssize_t i = 0; i < nargs; i++) {`
`@@ -505,7 +507,10 @@ match_class(PyThreadState tstate, PyObject subject, PyObject *type,`
`505`	`507`	`if (attr == NULL) {`
`506`	`508`	`goto fail;`
`507`	`509`	`}`
`508`		`- PyList_Append(attrs, attr);`
	`510`	`+ if (PyList_Append(attrs, attr) < 0) {`
	`511`	`+ Py_DECREF(attr);`
	`512`	`+ goto fail;`
	`513`	`+ }`
`509`	`514`	`Py_DECREF(attr);`
`510`	`515`	`}`
`511`	`516`	`}`
`@@ -518,7 +523,10 @@ match_class(PyThreadState tstate, PyObject subject, PyObject *type,`
`518`	`523`	`if (attr == NULL) {`
`519`	`524`	`goto fail;`
`520`	`525`	`}`
`521`		`- PyList_Append(attrs, attr);`
	`526`	`+ if (PyList_Append(attrs, attr) < 0) {`
	`527`	`+ Py_DECREF(attr);`
	`528`	`+ goto fail;`
	`529`	`+ }`
`522`	`530`	`Py_DECREF(attr);`
`523`	`531`	`}`
`524`	`532`	`Py_SETREF(attrs, PyList_AsTuple(attrs));`