python
diff --git a/‎Misc/NEWS.d/next/Core and Builtins/2023-10-02-23-17-08.gh-issue-110237._Xub0z.rst
Copy file name to clipboard
+1Lines changed: 1 addition & 0 deletions b/‎Misc/NEWS.d/next/Core and Builtins/2023-10-02-23-17-08.gh-issue-110237._Xub0z.rst
Copy file name to clipboard
+1Lines changed: 1 addition & 0 deletions
diff --git a/‎Python/ceval.c
Copy file name to clipboardExpand all lines: Python/ceval.c
+11-3Lines changed: 11 additions & 3 deletions b/‎Python/ceval.c
Copy file name to clipboardExpand all lines: Python/ceval.c
+11-3Lines changed: 11 additions & 3 deletions
@@ -0,0 +1 @@
+Fix missing error checks for calls to ``PyList_Append`` in ``_PyEval_MatchClass``.
@@ -506,7 +506,9 @@ _PyEval_MatchClass(PyThreadState *tstate, PyObject *subject, PyObject *type,
         }
         if (match_self) {
             // Easy. Copy the subject itself, and move on to kwargs.
-            PyList_Append(attrs, subject);
+            if (PyList_Append(attrs, subject) < 0) {
+                goto fail;
+            }
         }
         else {
             for (Py_ssize_t i = 0; i < nargs; i++) {
@@ -522,7 +524,10 @@ _PyEval_MatchClass(PyThreadState *tstate, PyObject *subject, PyObject *type,
                 if (attr == NULL) {
                     goto fail;
                 }
-                PyList_Append(attrs, attr);
+                if (PyList_Append(attrs, attr) < 0) {
+                    Py_DECREF(attr);
+                    goto fail;
+                }
                 Py_DECREF(attr);
             }
         }
@@ -535,7 +540,10 @@ _PyEval_MatchClass(PyThreadState *tstate, PyObject *subject, PyObject *type,
         if (attr == NULL) {
             goto fail;
         }
-        PyList_Append(attrs, attr);
+        if (PyList_Append(attrs, attr) < 0) {
+            Py_DECREF(attr);
+            goto fail;
+        }
         Py_DECREF(attr);
     }
     Py_SETREF(attrs, PyList_AsTuple(attrs));
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix missing error checks for calls to ``PyList_Append`` in ``_PyEval_MatchClass``.
Original file line number	Diff line number	Diff line change
`@@ -506,7 +506,9 @@ _PyEval_MatchClass(PyThreadState tstate, PyObject subject, PyObject *type,`
`506`	`506`	`}`
`507`	`507`	`if (match_self) {`
`508`	`508`	`// Easy. Copy the subject itself, and move on to kwargs.`
`509`		`- PyList_Append(attrs, subject);`
	`509`	`+ if (PyList_Append(attrs, subject) < 0) {`
	`510`	`+ goto fail;`
	`511`	`+ }`
`510`	`512`	`}`
`511`	`513`	`else {`
`512`	`514`	`for (Py_ssize_t i = 0; i < nargs; i++) {`
`@@ -522,7 +524,10 @@ _PyEval_MatchClass(PyThreadState tstate, PyObject subject, PyObject *type,`
`522`	`524`	`if (attr == NULL) {`
`523`	`525`	`goto fail;`
`524`	`526`	`}`
`525`		`- PyList_Append(attrs, attr);`
	`527`	`+ if (PyList_Append(attrs, attr) < 0) {`
	`528`	`+ Py_DECREF(attr);`
	`529`	`+ goto fail;`
	`530`	`+ }`
`526`	`531`	`Py_DECREF(attr);`
`527`	`532`	`}`
`528`	`533`	`}`
`@@ -535,7 +540,10 @@ _PyEval_MatchClass(PyThreadState tstate, PyObject subject, PyObject *type,`
`535`	`540`	`if (attr == NULL) {`
`536`	`541`	`goto fail;`
`537`	`542`	`}`
`538`		`- PyList_Append(attrs, attr);`
	`543`	`+ if (PyList_Append(attrs, attr) < 0) {`
	`544`	`+ Py_DECREF(attr);`
	`545`	`+ goto fail;`
	`546`	`+ }`
`539`	`547`	`Py_DECREF(attr);`
`540`	`548`	`}`
`541`	`549`	`Py_SETREF(attrs, PyList_AsTuple(attrs));`